This works fine in most places. However, interning (`sys.intern`) a
`SafeString` does not work, it needs to be converted to a regular string
first.
I use slugify to generate file names and passing it on to pathlib.Path.
Path interns strings and this breaks:
{{{
>>> from django.utils.text import slugify
>>> import pathlib
>>> pathlib.Path(slugify('foo'))
Traceback (most recent call last):
File "<input>", line 1, in <module>
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 999, in __new__
self = cls._from_parts(args, init=False)
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 656, in _from_parts
drv, root, parts = self._parse_args(args)
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 649, in _parse_args
return cls._flavour.parse_parts(parts)
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 69, in parse_parts
parsed.append(sys.intern(rel))
TypeError: can't intern SafeText
>>> pathlib.Path(str(slugify('foo')))
Traceback (most recent call last):
File "<input>", line 1, in <module>
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 999, in __new__
self = cls._from_parts(args, init=False)
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 656, in _from_parts
drv, root, parts = self._parse_args(args)
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 649, in _parse_args
return cls._flavour.parse_parts(parts)
File
"/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/pathlib.py",
line 69, in parse_parts
parsed.append(sys.intern(rel))
TypeError: can't intern SafeText
>>> pathlib.Path(slugify('foo') + '') # workaround
PosixPath('foo')
}}}
The only way to work around this is to use some kind of string operation
that will turn it into a native string but that feels like a workaround.
Maybe the problem is not SafeString but rather that
`django.utils.text.slugify` that does return a SafeString instead of a
regular string? The builtin slugify filter could still return a safe
string?
--
Ticket URL: <https://code.djangoproject.com/ticket/29412>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* stage: Unreviewed => Accepted
Comment:
I would also question the usage of `mark_safe` in `slugify`. I think the
only backwards incompatibility would be that the result of adding a
`SafeString` to a `slugify()` value would not be safe. I don't think it's
much of an issue, if it's documented in release notes.
--
Ticket URL: <https://code.djangoproject.com/ticket/29412#comment:1>
* owner: nobody => Windson yang
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/29412#comment:2>
* type: Uncategorized => Bug
--
Ticket URL: <https://code.djangoproject.com/ticket/29412#comment:3>
* owner: Windson yang => (none)
* status: assigned => new
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/10179 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29412#comment:4>
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29412#comment:5>
* owner: (none) => Tim Graham <timograham@…>
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"b004bd62e83588fdb0e533fdeec993aec358281d" b004bd62]:
{{{
#!CommitTicketReference repository=""
revision="b004bd62e83588fdb0e533fdeec993aec358281d"
Fixed #29412 -- Stopped marking slugify() result as HTML safe.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29412#comment:6>