Re: [Django] #8952: Refactor a Django "site" to be just another view function

23 views
Skip to first unread message

Django

unread,
Dec 11, 2011, 1:46:56 PM12/11/11
to django-...@googlegroups.com
#8952: Refactor a Django "site" to be just another view function
-------------------------------+-----------------------------------------
Reporter: simon | Owner: nobody
Type: New feature | Status: new
Component: contrib.sites | Version: 1.0
Severity: Normal | Resolution:
Keywords: djangocon | Triage Stage: Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
Changes (by aaugustin):

* ui_ux: => 0
* easy: => 0
* stage: Design decision needed => Someday/Maybe


Comment:

I'm not sure if it's useful to keep this ticket open after three years.
Several paradigms have shifted since then.

--
Ticket URL: <https://code.djangoproject.com/ticket/8952#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 12, 2011, 12:41:22 AM12/12/11
to django-...@googlegroups.com
#8952: Refactor a Django "site" to be just another view function
-------------------------------+-----------------------------------------
Reporter: simon | Owner: nobody
Type: New feature | Status: new
Component: contrib.sites | Version: 1.0
Severity: Normal | Resolution:
Keywords: djangocon | Triage Stage: Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------

Comment (by carljm):

Replying to [comment:6 aaugustin]:

> I'm not sure if it's useful to keep this ticket open after three years.
Several paradigms have shifted since then.

FWIW I think this is a really good idea - I don't see anything that's
shifted that would make this inapplicable. It'd be one (significant) step
towards reducing the dependency on global settings everywhere.

I'm not in favor of closing this ticket, but Someday/Maybe is an
appropriate state for it. I'd be happy to upgrade it to Accepted, though,
if someone came along who was serious about working on it :-)

--
Ticket URL: <https://code.djangoproject.com/ticket/8952#comment:7>

Django

unread,
Aug 28, 2015, 12:54:03 AM8/28/15
to django-...@googlegroups.com
#8952: Refactor a Django "site" to be just another view function
-------------------------------------+-------------------------------------
Reporter: simon | Owner: Y3K
Type: New feature | Status: assigned
Component: contrib.sites | Version: master
Severity: Normal | Resolution:
Keywords: djangocon | Triage Stage: Ready for
| checkin

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Y3K):

* owner: nobody => Y3K
* status: new => assigned
* version: 1.0 => master
* stage: Someday/Maybe => Ready for checkin


Comment:

Replying to [comment:7 carljm]:


> FWIW I think this is a really good idea - I don't see anything that's
shifted that would make this inapplicable. It'd be one (significant) step
towards reducing the dependency on global settings everywhere.
>
> I'm not in favor of closing this ticket, but Someday/Maybe is an
appropriate state for it. I'd be happy to upgrade it to Accepted, though,
if someone came along who was serious about working on it :-)

Hello carljm, nice to meet you.

I'd like to review and work on this, if it stills beign a valid ticket. I
don't get what's the new desired behaviour exactly, but it sounds
interesting.

* I assigned this to me since it have been forgotten for years, I don't
think anyone else would be interested on it.
* Its version from 1.0 to master, because the feature would be added to it
instead of 1.0
* Its state has been changed to ''Ready for Checkin'', I assume would be
before ''Accepted'', since I don't know if after 4 years we'll be
interested on Accept it.

Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/8952#comment:8>

Django

unread,
Aug 28, 2015, 8:53:09 AM8/28/15
to django-...@googlegroups.com
#8952: Refactor a Django "site" to be just another view function
-------------------------------+-----------------------------------------

Reporter: simon | Owner: Y3K
Type: New feature | Status: assigned
Component: contrib.sites | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Someday/Maybe

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
Changes (by timgraham):

* keywords: djangocon =>
* stage: Ready for checkin => Someday/Maybe


Comment:

Hi, please see the
[https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#triage-workflow triage workflow] to understand what "Ready for
checkin" means. You are welcome to work on this if you like, although it
seems non-trivial so I wouldn't recommend this as a first contribution,
especially if you don't have an idea of where to start. You'll need to
come up with a design plan and present it on the DevelopersMailingList to
get feedback on your plan. Once that plan is approved, we can move the
ticket to "Accepted". Thanks!

--
Ticket URL: <https://code.djangoproject.com/ticket/8952#comment:9>

Django

unread,
Aug 28, 2015, 9:35:13 AM8/28/15
to django-...@googlegroups.com
#8952: Refactor a Django "site" to be just another view function
-------------------------------+-----------------------------------------
Reporter: simon | Owner: Y3K
Type: New feature | Status: assigned
Component: contrib.sites | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------

Comment (by Y3K):

Replying to [comment:9 timgraham]:


> Hi, please see the
[https://docs.djangoproject.com/en/dev/internals/contributing/triaging-
tickets/#triage-workflow triage workflow] to understand what "Ready for
checkin" means. You are welcome to work on this if you like, although it
seems non-trivial so I wouldn't recommend this as a first contribution,
especially if you don't have an idea of where to start. You'll need to
come up with a design plan and present it on the DevelopersMailingList to
get feedback on your plan. Once that plan is approved, we can move the
ticket to "Accepted". Thanks!

Oh! That was the page I was looking for and couldn't find, thank you!
(maybe an icon with help text next to the Triage status select would be
neat).

By the way, nice to meet you Tim!

Regard the ticket, I don't know yet what's exactly the goal behind it, but
I feel pretty confident about beign capable to work on it. I've been a
Django user since 0.7 or so.

Would be possible to get a little more explicit example about the idea
behind this ticket so I can come up with a plan?

Thank you.

--
Ticket URL: <https://code.djangoproject.com/ticket/8952#comment:10>

Django

unread,
Aug 28, 2015, 5:07:02 PM8/28/15
to django-...@googlegroups.com
#8952: Refactor a Django "site" to be just another view function
-------------------------------+-----------------------------------------
Reporter: simon | Owner: Y3K
Type: New feature | Status: closed
Component: contrib.sites | Version: master
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage: Someday/Maybe
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+-----------------------------------------
Changes (by carljm):

* status: assigned => closed
* resolution: => wontfix


Comment:

Aymeric was right here, and I was wrong. This is the sort of huge refactor
that's unlikely to be successful unless taken on by an experienced core
developer, and may not even be feasible then. I still think it would be
interesting to see what could be done along these lines, but I don't think
there's any value to keeping it open as a ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/8952#comment:11>

Reply all
Reply to author
Forward
0 new messages