Re: [Django] #15522: delete_model on admin delete action

11 views
Skip to first unread message

Django

unread,
Apr 5, 2012, 9:01:31 AM4/5/12
to django-...@googlegroups.com
#15522: delete_model on admin delete action
-------------------------------+------------------------------------
Reporter: Divad | Owner: nobody
Type: New feature | Status: reopened
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: delete_model | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by shelldweller):

* cc: shelldweller (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/15522#comment:10>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 10, 2012, 9:24:15 AM4/10/12
to django-...@googlegroups.com
#15522: delete_model on admin delete action
-------------------------------+------------------------------------
Reporter: Divad | Owner: nobody
Type: New feature | Status: reopened
Component: contrib.admin | Version: SVN
Severity: Normal | Resolution:
Keywords: delete_model | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by omerd1):

* cc: omerd1 (added)


Comment:

I've encountered this 'feature' while debugging my delete_model.

Another working workaround is to register for pre_delete signal

--
Ticket URL: <https://code.djangoproject.com/ticket/15522#comment:11>

Django

unread,
Jun 20, 2016, 9:26:38 PM6/20/16
to django-...@googlegroups.com
#15522: delete_model on admin delete action
-------------------------------+------------------------------------
Reporter: Divad | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: delete_model | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by czpython):

While I agree that we should keep consistency, in this case I think both
actions should be treated separately.
One deletes a single object, the other deletes multiple objects.
Hooking a pre delete signal or calling delete_model have big impact on
performance depending on how many objects
are being deleted.

I'd like to propose a change in the delete action that allows for hooking
into it before the deletion takes place,
maybe a method in the {{{ModelAdmin}}} class?

--
Ticket URL: <https://code.djangoproject.com/ticket/15522#comment:13>

Django

unread,
Jun 20, 2016, 9:31:43 PM6/20/16
to django-...@googlegroups.com
#15522: delete_model on admin delete action
-------------------------------+------------------------------------
Reporter: Divad | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: delete_model | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by czpython):

* cc: commonzenpython@… (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/15522#comment:14>

Reply all
Reply to author
Forward
0 new messages