[Django] #32144: makemessages leaves temporary files in an error case
Django
-------------------------------------+-------------------------------------
Reporter: boxed | Owner: nobody
Type: Bug | Status: new
Component: Core | Version: 3.1
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
If you run makemessages and you end up with the error message "Unable to
find a locale path to store translations for file [...]", you get a lot of
temporary files left over that you need to clean up.
The fix is pretty trivial so a PR is on the way.
--
Ticket URL: <https://code.djangoproject.com/ticket/32144>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: boxed | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
PR at https://github.com/django/django/pull/13609
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: boxed | Owner: boxed
Type: Bug | Status: assigned
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => assigned
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* owner: nobody => boxed
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: boxed | Owner: boxed
Type: Bug | Status: assigned
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
Comment:
Author updated patch with a test and seeks feedback on new approach.
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:3>
Django
-------------------------------------+-------------------------------------
| Hovmöller
Type: Bug | Status: assigned
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
Comment:
Verified regression test fails on main. Speaking of which, the regression
test targets the additional case Anders found, so the title of the patch
might be edited to be made more general, but I will leave that for others.
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Anders Hovmöller | Owner: Anders
| Hovmöller
Type: Bug | Status: assigned
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson):
[https://github.com/django/django/pull/14578 Alternate PR based on review
comments].
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Anders Hovmöller | Owner: Anders
| Hovmöller
Component: Core (Management | Version: 3.1
commands) |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Carlton Gibson <carlton@…>):
In [changeset:"4af162d4de5d60cef42e4707d821c1d6c0c99be0" 4af162d]:
{{{
#!CommitTicketReference repository=""
revision="4af162d4de5d60cef42e4707d821c1d6c0c99be0"
Refs #32144 -- Made makemessages remove temporary files on preprocessing
error.
Co-authored-by: Anders Hovmöller <anders.h...@dryft.se>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Anders Hovmöller | Owner: Anders
| Hovmöller
Type: Bug | Status: closed
Component: Core (Management | Version: 3.1
commands) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"dfa7781033a0d62e84c632ef216208d29e7633c8" dfa77810]:
{{{
#!CommitTicketReference repository=""
revision="dfa7781033a0d62e84c632ef216208d29e7633c8"
Fixed #32144 -- Made makemessages remove temporary files when locale path
doesn't exist.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32144#comment:6>