[Django] #23625: Is CacheClass still needed "For backwards compatibility"?

7 views
Skip to first unread message

Django

unread,
Oct 9, 2014, 9:15:00 AM10/9/14
to django-...@googlegroups.com
#23625: Is CacheClass still needed "For backwards compatibility"?
-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: 1.7
Component: Core (Cache system) | Keywords: cacheclass
Severity: Normal | compatibility
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
All cache backends, excluding memcached, have a CacheClass defined at the
end of the file "For backwards compatibility". From what I can gather this
means pre 1.3 compatibility.

The memcached backend has dropped this CacheClass (in 1.6 or 1.7). Does
this mean all other cache backend can also drop this?

--
Ticket URL: <https://code.djangoproject.com/ticket/23625>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 9, 2014, 10:26:41 AM10/9/14
to django-...@googlegroups.com
#23625: Remove backwards compatibility CacheClass shim in cache backends

-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cacheclass | Needs documentation: 0
compatibility | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_tests: => 0
* version: 1.7 => master
* needs_docs: => 0
* stage: Unreviewed => Accepted


Comment:

With a mention in the release notes it's probably fine.

--
Ticket URL: <https://code.djangoproject.com/ticket/23625#comment:1>

Django

unread,
Oct 9, 2014, 10:28:58 AM10/9/14
to django-...@googlegroups.com
#23625: Remove backwards compatibility CacheClass shim in cache backends
-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: jaap3
Type: | Status: assigned

Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cacheclass | Needs documentation: 0
compatibility | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by jaap3):

* status: new => assigned
* owner: nobody => jaap3


--
Ticket URL: <https://code.djangoproject.com/ticket/23625#comment:2>

Django

unread,
Oct 10, 2014, 4:35:49 AM10/10/14
to django-...@googlegroups.com
#23625: Remove backwards compatibility CacheClass shim in cache backends
-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: jaap3
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cacheclass | Needs documentation: 0
compatibility | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by jaap3):

Should I put the note in `internals/deprecation.txt` (that's where the
removal of `django.core.cache.backends.memcached.CacheClass` is mentioned)
or `releases/1.8.txt`?

--
Ticket URL: <https://code.djangoproject.com/ticket/23625#comment:3>

Django

unread,
Oct 10, 2014, 7:14:44 AM10/10/14
to django-...@googlegroups.com
#23625: Remove backwards compatibility CacheClass shim in cache backends
-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: jaap3
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cacheclass | Needs documentation: 0
compatibility | Patch needs improvement: 0
Has patch: 0 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by timgraham):

I would mention it as a backwards incompatible change in the 1.8 release
notes.

--
Ticket URL: <https://code.djangoproject.com/ticket/23625#comment:4>

Django

unread,
Oct 10, 2014, 7:25:36 AM10/10/14
to django-...@googlegroups.com
#23625: Remove backwards compatibility CacheClass shim in cache backends
-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: jaap3
Type: | Status: assigned
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: cacheclass | Needs documentation: 0
compatibility | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0

Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by jaap3):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/23625#comment:5>

Django

unread,
Oct 10, 2014, 8:43:57 AM10/10/14
to django-...@googlegroups.com
#23625: Remove backwards compatibility CacheClass shim in cache backends
-------------------------------------+-------------------------------------
Reporter: jaap3 | Owner: jaap3
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Core (Cache system) | Resolution: fixed

Severity: Normal | Triage Stage: Accepted
Keywords: cacheclass | Needs documentation: 0
compatibility | Patch needs improvement: 0
Has patch: 1 | UI/UX: 0
Needs tests: 0 |
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"1b5918f160365b97986f21da1a7c35ffd2d5b0b0"]:
{{{
#!CommitTicketReference repository=""
revision="1b5918f160365b97986f21da1a7c35ffd2d5b0b0"
Fixed #23625 -- Removed CacheClass shim
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23625#comment:6>

Reply all
Reply to author
Forward
0 new messages