[Django] #28017: Add option to specify a different secret to PasswordResetTokenGenerator
Django
----------------------------------------+------------------------
Reporter: jannh | Owner: nobody
Type: New feature | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
----------------------------------------+------------------------
In the PasswordResetTokenGenerator class, it is very difficult to use a
secret different from settings.SECRET_KEY. In Django however, it would be
very easy to add an attribute "secret" to the class, which defaults to
settings.SECRET_KEY and is handed to "salted_hmac" in the method
"_make_token_with_timestamp".
Currently, one would have to overwrite the _make_token_with_timestamp
method, which is not documented and likely to change, or one could misuse
modify_settings or override_settings in production.
Our usecase is, that we have a site for our employees and a self-service-
site for customers deployed on different servers and with different
SECRET_KEYs. Both sites should be able to generate Reset-Links for the
self-service site.
--
Ticket URL: <https://code.djangoproject.com/ticket/28017>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Jann Haber | Owner: Jann Haber
Type: New feature | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jann Haber):
* owner: nobody => Jann Haber
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:1>
Django
Reporter: Jann Haber | Owner: Jann Haber
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
Changes (by Jann Haber):
* has_patch: 0 => 1
* easy: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:2>
Django
Reporter: Jann Haber | Owner: Jann Haber
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:3>
Django
Reporter: Jann Haber | Owner: Jann Haber
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
------------------------------+--------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:4>
Django
Reporter: Jann Haber | Owner: Jann Haber
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
* needs_better_patch: 1 => 0
Comment:
I updated the PR according to Tim's comments. Thank you for the review!
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:5>
Django
Reporter: Jann Haber | Owner: Jann Haber
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"c930c241f8f1ccf3a7848b843628eacdb983d70a" c930c24]:
{{{
#!CommitTicketReference repository=""
revision="c930c241f8f1ccf3a7848b843628eacdb983d70a"
Fixed #28017 -- Allowed customizing PasswordResetTokenGenerator's secret.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:6>
Django
Reporter: Jann Haber | Owner: Jann Haber
Type: New feature | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
------------------------------+--------------------------------------
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"b13af4752fa3e5e7c08163902f32260a50f69ef7" b13af47]:
{{{
#!CommitTicketReference repository=""
revision="b13af4752fa3e5e7c08163902f32260a50f69ef7"
Refs #28017 -- Added test for PasswordResetTokenGenerator subclass with a
custom secret.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28017#comment:7>