[Django] #23799: squashmigrations --no-optimize still optimizes
Django
----------------------------+--------------------
Reporter: Tilka | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
----------------------------+--------------------
The --no-optimize option doesn't have any effect.
--
Ticket URL: <https://code.djangoproject.com/ticket/23799>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tilka | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tilka):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> The --no-optimize option doesn't have any effect.
New description:
The --no-optimize option doesn't have any effect.
See pull request 3500.
--
Comment:
See https://github.com/django/django/pull/3500
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:1>
Django
Reporter: Tilka | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by MarkusH):
* cc: info+coding@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:2>
Django
Reporter: Tilka | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by MarkusH):
* needs_tests: 0 => 1
Comment:
Though its a rather small patch I'd like to see a test for the now working
feature.
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:3>
Django
Reporter: Tilka | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:4>
Django
Reporter: Tilka | Owner: deni
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Changes (by deni):
* status: new => assigned
* owner: nobody => deni
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:5>
Django
Reporter: Tilka | Owner: avojnovicDk
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Changes (by avojnovicDk):
* owner: deni => avojnovicDk
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:6>
Django
Reporter: Tilka | Owner: avojnovicDk
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Comment (by Tilka):
@avojnovicDk: Are you at DjangoUnderTheHood? I forgot to set the owner,
now we might be working on the same thing.
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:7>
Django
Reporter: Tilka | Owner: avojnovicDk
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Changes (by yamila-moreno):
* needs_tests: 1 => 0
Comment:
there is PR
https://github.com/django/django/pull/3521
we didn't see this thread updated till the login... I made the PR without
knowing...
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:8>
Django
Reporter: Tilka | Owner: Tilka
Type: Bug | Status: assigned
Component: Migrations | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tilka):
* owner: avojnovicDk => Tilka
Comment:
After talking with yamila-moreno, we agreed to have me finish this ticket.
Sorry avojnovicDk, haven't heard anything from you, so I'll just change
the owner (again).
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:9>
Django
Reporter: Tilka | Owner: Tilka
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by avojnovicDk):
I just saw this. :) Yes, I am at DjangoUnderTheHood and was just working
on this. I'll find something else to work on, no problem. It's great that
the ticket is finished.
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:10>
Django
Reporter: Tilka | Owner: Tilka
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by MarkusH):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:11>
Django
Reporter: Tilka | Owner: Tilka
Component: Migrations | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d18810131995dac63f9d89b0beaeadfc935130aa"]:
{{{
#!CommitTicketReference repository=""
revision="d18810131995dac63f9d89b0beaeadfc935130aa"
Fixed #23799 -- Made makemigrations respect --no-optimize.
Thanks to yamila-moreno for the idea of a skip message.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:12>
Django
Reporter: Tilka | Owner: Tilka
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"dfcac7d7f5f1f108ae2c561f0f755f08d75a1c27"]:
{{{
#!CommitTicketReference repository=""
revision="dfcac7d7f5f1f108ae2c561f0f755f08d75a1c27"
[1.7.x] Fixed #23799 -- Made makemigrations respect --no-optimize.
Thanks to yamila-moreno for the idea of a skip message.
Backport of d18810131995dac63f9d89b0beaeadfc935130aa from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23799#comment:13>