[Django] #24019: Documentation of GenericRelation should be updated

13 views
Skip to first unread message

Django

unread,
Dec 17, 2014, 11:03:52 PM12/17/14
to django-...@googlegroups.com
#24019: Documentation of GenericRelation should be updated
-----------------------------------------+------------------------
Reporter: shaib | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
This ticket collects a few documentation issues:

* Following #24002:
* Release notes
* Consider documenting the behavior of filtering on the generic
relation
* Fix the note on `GenericRelation`s and aggregation (they do work now)

--
Ticket URL: <https://code.djangoproject.com/ticket/24019>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 18, 2014, 8:19:21 AM12/18/14
to django-...@googlegroups.com
#24019: Documentation of GenericRelation should be updated
-------------------------------+------------------------------------

Reporter: shaib | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by timgraham):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/24019#comment:1>

Django

unread,
Oct 29, 2015, 5:46:55 PM10/29/15
to django-...@googlegroups.com
#24019: Docs inaccurately claim aggregation doesn't work with GenericRelation
-------------------------------+------------------------------------

Reporter: shaib | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

The note about aggregation not working was in response to #10870 which has
been fixed since 1.6 at least.

[https://github.com/django/django/pull/5510 PR] to address that.

I'm not sure release notes or further documentation is needed for #24002,
that just looks like a bug fix to me.

--
Ticket URL: <https://code.djangoproject.com/ticket/24019#comment:2>

Django

unread,
Oct 30, 2015, 10:36:47 AM10/30/15
to django-...@googlegroups.com
#24019: Docs inaccurately claim aggregation doesn't work with GenericRelation
-------------------------------+------------------------------------
Reporter: shaib | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"e19bd086d608c981098130a49e406de91dcc3d26" e19bd086]:
{{{
#!CommitTicketReference repository=""
revision="e19bd086d608c981098130a49e406de91dcc3d26"
Fixed #24019 -- Fixed inaccurate docs about GenericRelation not supporting
aggregation.

This works at least as far back as Django 1.6 according to the test
added in refs #10870.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24019#comment:3>

Django

unread,
Oct 30, 2015, 10:38:17 AM10/30/15
to django-...@googlegroups.com
#24019: Docs inaccurately claim aggregation doesn't work with GenericRelation
-------------------------------+------------------------------------
Reporter: shaib | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"78f9805755c736573cb45f512345f064c88a680e" 78f98057]:
{{{
#!CommitTicketReference repository=""
revision="78f9805755c736573cb45f512345f064c88a680e"
[1.9.x] Fixed #24019 -- Fixed inaccurate docs about GenericRelation not
supporting aggregation.

This works at least as far back as Django 1.6 according to the test
added in refs #10870.

Backport of e19bd086d608c981098130a49e406de91dcc3d26 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24019#comment:4>

Django

unread,
Oct 30, 2015, 10:38:18 AM10/30/15
to django-...@googlegroups.com
#24019: Docs inaccurately claim aggregation doesn't work with GenericRelation
-------------------------------+------------------------------------
Reporter: shaib | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"5adeb410253dcba2215dd8274255a6dd897f14d1" 5adeb41]:
{{{
#!CommitTicketReference repository=""
revision="5adeb410253dcba2215dd8274255a6dd897f14d1"
[1.8.x] Fixed #24019 -- Fixed inaccurate docs about GenericRelation not
supporting aggregation.

This works at least as far back as Django 1.6 according to the test
added in refs #10870.

Backport of e19bd086d608c981098130a49e406de91dcc3d26 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24019#comment:5>

Reply all
Reply to author
Forward
0 new messages