[Django] #26946: Clarify documentation on customizing the ignored pattern list for `collectstatic`

32 views
Skip to first unread message

Django

unread,
Jul 25, 2016, 8:45:21 AM7/25/16
to django-...@googlegroups.com
#26946: Clarify documentation on customizing the ignored pattern list for
`collectstatic`
-------------------------------+--------------------
Reporter: rixx | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
The docs (https://docs.djangoproject.com/en/1.10/ref/contrib/staticfiles
/#customizing-the-ignored-pattern-list) only include two very terse
sentences on the new feature of customizing the ignored pattern list for
`collectstatic` via code instead of invocation parameters. The second
sentence ends with

override the ignore_patterns attribute of this class and specify that
class path inside your INSTALLED_APPS setting.

If you just follow those instructions without removing 'staticfiles' from
the INSTALLED_APPS list, you'll get the error `Application labels aren't
unique, duplicates: staticfiles`.

--
Ticket URL: <https://code.djangoproject.com/ticket/26946>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 25, 2016, 9:22:07 AM7/25/16
to django-...@googlegroups.com
#26946: Clarify documentation on customizing the ignored pattern list for
`collectstatic`
-------------------------------------+-------------------------------------
Reporter: rixx | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by rixx):

* needs_better_patch: => 0
* type: Uncategorized => Cleanup/optimization
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26946#comment:1>

Django

unread,
Jul 25, 2016, 9:37:52 AM7/25/16
to django-...@googlegroups.com
#26946: Clarify documentation on customizing the ignored pattern list for
`collectstatic`
--------------------------------------+------------------------------------
Reporter: rixx | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

Is this enough?
{{{#!diff
diff --git a/docs/ref/contrib/staticfiles.txt
b/docs/ref/contrib/staticfiles.txt
index 5f2e5f9..78f09b9 100644
--- a/docs/ref/contrib/staticfiles.txt
+++ b/docs/ref/contrib/staticfiles.txt
@@ -136,8 +136,9 @@ Customizing the ignored pattern list
The default ignored pattern list, ``['CVS', '.*', '*~']``, can be
customized in
a more persistent way than providing the ``--ignore`` command option at
each
``collectstatic`` invocation. Provide a custom
:class:`~django.apps.AppConfig`
-class, override the ``ignore_patterns`` attribute of this class and
specify
-that class path inside your :setting:`INSTALLED_APPS` setting:
+class, override the ``ignore_patterns`` attribute of this class and
replace
+``'django.contrib.staticfiles'`` with that class path in your
+:setting:`INSTALLED_APPS` setting:

.. code-block:: python
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26946#comment:2>

Django

unread,
Jul 25, 2016, 9:42:26 AM7/25/16
to django-...@googlegroups.com
#26946: Clarify documentation on customizing the ignored pattern list for
`collectstatic`
--------------------------------------+------------------------------------
Reporter: rixx | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.10

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by rixx):

I'd say so, thanks! (This issue was actually mentioned via #django on
freenode by jleclanche.)

--
Ticket URL: <https://code.djangoproject.com/ticket/26946#comment:3>

Django

unread,
Jul 25, 2016, 10:06:08 AM7/25/16
to django-...@googlegroups.com
#26946: Clarify documentation on customizing the ignored pattern list for
`collectstatic`
--------------------------------------+------------------------------------
Reporter: rixx | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"ec4a6b33a9af7f7c266c92b4ffb9b0a49ee5b1eb" ec4a6b33]:
{{{
#!CommitTicketReference repository=""
revision="ec4a6b33a9af7f7c266c92b4ffb9b0a49ee5b1eb"
Fixed #26946 -- Clarified instructions for customizing collectstatic's
ignore_patterns.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26946#comment:4>

Django

unread,
Jul 25, 2016, 10:07:02 AM7/25/16
to django-...@googlegroups.com
#26946: Clarify documentation on customizing the ignored pattern list for
`collectstatic`
--------------------------------------+------------------------------------
Reporter: rixx | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.10

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"13c107b149bcfed13217a8f9f238a6e19f87c9e7" 13c107b]:
{{{
#!CommitTicketReference repository=""
revision="13c107b149bcfed13217a8f9f238a6e19f87c9e7"
[1.10.x] Fixed #26946 -- Clarified instructions for customizing
collectstatic's ignore_patterns.

Backport of ec4a6b33a9af7f7c266c92b4ffb9b0a49ee5b1eb from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26946#comment:5>

Reply all
Reply to author
Forward
0 new messages