[Django] #23282: Change confusing text about "Inheritance and reverse relations"
Django
-------------------------------------+--------------------
Reporter: knowledgepoint-devs | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 1.4
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+--------------------
https://docs.djangoproject.com/en/1.6/topics/db/models/#inheritance-and-
reverse-relations says "If you are putting those types of relations on a
subclass of another model".
I think it should read "If you are putting those types of relations on
another subclass of the parent model"?
--
Ticket URL: <https://code.djangoproject.com/ticket/23282>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: knowledgepoint-devs | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bmispelon):
* needs_better_patch: => 0
* needs_tests: => 0
* version: 1.4 => master
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Even after reading it a few times, I still understand what the
documentation is trying to tell me.
It also seems to me that the example chosen is wrong since the following
models (taken straight from the documentation) validate fine on Django
1.6:
{{{#!python
class Place(models.Model):
name = models.CharField(max_length=50)
address = models.CharField(max_length=80)
class Restaurant(Place):
serves_hot_dogs = models.BooleanField()
serves_pizza = models.BooleanField()
class Supplier(Place):
# Notice the lack of a related_name
customers = models.ManyToManyField(Restaurant)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23282#comment:1>
Django
Reporter: knowledgepoint-devs | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/23282#comment:2>
Django
Reporter: knowledgepoint-devs | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: Documentation | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by claudep):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/23282#comment:3>
Django
Reporter: knowledgepoint-devs | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Documentation | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"700618706425ae15888b9e60bdc7a00dd0b32a2f"]:
{{{
#!CommitTicketReference repository=""
revision="700618706425ae15888b9e60bdc7a00dd0b32a2f"
Fixed #23282 -- Corrected inheritance and reverse relations example.
Thanks knowledgepoint-devs for the report and claudep for review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23282#comment:4>
Django
Reporter: knowledgepoint-devs | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Documentation | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"d1e4fb996bd969c9a5d1dc4546b3fd46766ad25e"]:
{{{
#!CommitTicketReference repository=""
revision="d1e4fb996bd969c9a5d1dc4546b3fd46766ad25e"
[1.6.x] Fixed #23282 -- Corrected inheritance and reverse relations
example.
Thanks knowledgepoint-devs for the report and claudep for review.
Backport of 7006187064 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23282#comment:6>
Django
Reporter: knowledgepoint-devs | Owner: nobody
Type: | Status: closed
Cleanup/optimization | Version: master
Component: Documentation | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"20e3a004ac88b127a51bb332ca2653fe06a19a97"]:
{{{
#!CommitTicketReference repository=""
revision="20e3a004ac88b127a51bb332ca2653fe06a19a97"
[1.7.x] Fixed #23282 -- Corrected inheritance and reverse relations
example.
Thanks knowledgepoint-devs for the report and claudep for review.
Backport of 7006187064 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/23282#comment:5>