Re: [Django] #13629: Admin Changelist: add app-model_name class to <body> tag
Django
---------------------------------------+-------------------------------
Reporter: naos | Owner: patrick91
Type: New feature | Status: new
Milestone: | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 1
Patch needs improvement: 1 | Easy pickings: 1
UI/UX: 0 |
---------------------------------------+-------------------------------
Changes (by patrick91):
* owner: nobody => patrick91
* ui_ux: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
---------------------------------------+-------------------------------
Reporter: naos | Owner: patrick91
Milestone: | Component: contrib.admin
Version: 1.3 | Severity: Normal
Resolution: fixed | Keywords:
Needs documentation: 0 | Needs tests: 1
---------------------------------------+-------------------------------
Changes (by patrick91):
* status: new => closed
* needs_better_patch: 1 => 0
* version: 1.2 => 1.3
* resolution: => fixed
Comment:
I've updated the code to work with django 1.3. Also I've added more
classes.
'''Class added:'''
* In home: dashboard home
* In application model list: dashboard app_label
* In change form: app_label-modelname change-form
* In change list: app_label-modelname change-list
* In delete confirmation: app_label-modelname delete-confirmation
* In delete selected confirmation: app_label-modelname delete-confirmation
delete-selected-confirmation
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:7>
Django
---------------------------------------+-------------------------------
Reporter: naos | Owner: patrick91
Version: 1.3 | Severity: Normal
---------------------------------------+-------------------------------
Changes (by julien):
* status: closed => reopened
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* resolution: fixed =>
Comment:
This isn't fixed until it has been checked in ;)
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:8>
Django
---------------------------------------+-------------------------------
Reporter: naos | Owner:
Version: 1.3 | Severity: Normal
Resolution: | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 1 | Needs tests: 1
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
---------------------------------------+-------------------------------
* owner: patrick91 =>
* status: reopened => new
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:9>
Django
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Changes (by phillip_c_chin@…):
* needs_tests: 1 => 0
Comment:
I applied the more-classes-in-admin.patch patch and added a unit test to
regressiontests/admin_views/test.py called
testAppModelNameInClassForBodyTag(). I submitted a pull request for this.
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:10>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by anonymous):
The pull request is here: https://github.com/django/django/pull/158
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:11>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner:
Type: New feature | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
-------------------------------+------------------------------------
* needs_better_patch: 0 => 1
Comment:
Thanks for your work. I've left some specific comments on the pull
request. Could you take a look and update it? Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:12>
Django
-------------------------------+------------------------------------
Type: New feature | Status: new
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* owner: => tcsorrel
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:13>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by tcsorrel):
* status: new => assigned
Comment:
New pull request can be found here :
https://github.com/django/django/pull/575
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:14>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by tcsorrel):
* needs_better_patch: 1 => 0
Comment:
Patch is updated with last test done in the same pull request
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:15>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Changes (by tcsorrel):
* needs_docs: 1 => 0
Comment:
I don't know how and where this ticket should be documented
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:16>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* needs_better_patch: 0 => 1
Comment:
Thanks a lot for the updated pull request!
I think the patch looks pretty good. I just have one main comment: I'm not
sure Selenium is really needed for the last test. Selenium tests are
usually quite slow to run, so if there's a way to use the dummy client
instead, then that would be preferable. See maybe if you can find similar
examples in `admin_views.tests.AdminActionsTest`.
Thanks again!
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:17>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by tcsorrel):
Thanks for the advice on sending post request more simply.
I changed the test client. And took also the opportunity to
- remove prefix redundant with assertContains message
- limit the test to check the body class app and model tag
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:18>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:19>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by julien):
Thanks a lot Thomas! Could you please update the pull request? I'll review
your changes as soon as I can. Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:20>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Component: contrib.admin | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
Comment (by julien):
Thank you for updating the pull request. I think everything looks great. I
just have 2 minor comments before merging your work. Could you please move
the tests to the `CSSTest` class inside `admin_views/tests.py`, and could
you make sure there are no trailing white spaces in the patch? Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:21>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* version: 1.3 => master
Comment:
Tests are moved CSSTest.
Trailing spaces are removed.
The ticket changes is rebased on master inside one commit.
Tests are passed.
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:22>
Django
-------------------------------+------------------------------------
Reporter: naos | Owner: tcsorrel
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"bb145e2c47d71b7f68280c00ced727442d2effa2"]:
{{{
#!CommitTicketReference repository=""
revision="bb145e2c47d71b7f68280c00ced727442d2effa2"
Fixed #13629 -- Added CSS classes to the `<body>` tag of some admin
templates to allow style customizations per app or per model.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/13629#comment:23>