[Django] #29593: Removal of QUERY_TERMS is not in 2.1 "features removed" page
Django
-------------------------------------------+------------------------
Reporter: Ryan Verner | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 2.1
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
django.db.models.sql.constants.QUERY_TERMS is removed in the upcoming 2.1;
https://github.com/django/django/commit/af69f14e7ba06bb7dee257ec02b885f4828c77ff
There is no mention of this in the release notes:
https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-
in-2-1
Lots of projects reference this, and will break when upgrading to 2.1
(Wagtail is one; I'm prepping a PR for them).
https://github.com/search?l=Python&q=from+django.db.models.sql.constants+import+QUERY_TERMS&type=Code
--
Ticket URL: <https://code.djangoproject.com/ticket/29593>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Ryan Verner | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 2.1
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* stage: Unreviewed => Accepted
Comment:
`QUERY_TERMS` was never documented as public API. As such it's not a
''Feature'' per se, and is not subject to the deprecation policy.
Having said that, I'm not unsympathetic to people running into this.
(Amongst others django-filter needed to make changes to work around it.)
It has been widely used; we should probably mention it. Perhaps in
Backwards incompatible changes in 2.1 > Miscellaneous.
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:1>
Django
Reporter: Ryan Verner | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 2.1
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
`QUERY_TERMS` was removed in 244cc401559e924355cf943b6b8e66ccf2f6da3a for
#26184.
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:2>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Documentation | Version: 2.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: new => assigned
* owner: nobody => Carlton Gibson
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:3>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
[https://github.com/django/django/pull/10227 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:4>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:5>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Ryan Verner:
Old description:
> django.db.models.sql.constants.QUERY_TERMS is removed in the upcoming
> 2.1;
>
> https://github.com/django/django/commit/af69f14e7ba06bb7dee257ec02b885f4828c77ff
>
> There is no mention of this in the release notes:
> https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-
> in-2-1
>
> Lots of projects reference this, and will break when upgrading to 2.1
> (Wagtail is one; I'm prepping a PR for them).
> https://github.com/search?l=Python&q=from+django.db.models.sql.constants+import+QUERY_TERMS&type=Code
New description:
django.db.models.sql.constants.QUERY_TERMS is removed in the upcoming 2.1;
https://github.com/django/django/commit/244cc401559e924355cf943b6b8e66ccf2f6da3a
(edit: fixed correct commit)
There is no mention of this in the release notes:
https://docs.djangoproject.com/en/2.1/releases/2.1/#features-removed-
in-2-1
Lots of projects reference this, and will break when upgrading to 2.1
(Wagtail is one; I'm prepping a PR for them).
https://github.com/search?l=Python&q=from+django.db.models.sql.constants+import+QUERY_TERMS&type=Code
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:6>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Ryan Verner):
Carlton: Thanks for linking to the correct commit; that's what I was
looking at but I linked to a different one for some reason. Changes look
good to me - indeed it's not a public API but the GitHub search above
indicates it's used quite a bit.
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:7>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Component: Documentation | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"5180015051f262b73559bb55a8e3fe6f551f8b68" 51800150]:
{{{
#!CommitTicketReference repository=""
revision="5180015051f262b73559bb55a8e3fe6f551f8b68"
Fixed #29593 -- Added QUERY_TERMS removal to 2.1 release notes.
Removed in 244cc401559e924355cf943b6b8e66ccf2f6da3a.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:9>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Component: Documentation | Version: 2.1
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"a67ebcb1cbd37e1fc9eddd2da1dda7f319c5ac1d" a67ebcb1]:
{{{
#!CommitTicketReference repository=""
revision="a67ebcb1cbd37e1fc9eddd2da1dda7f319c5ac1d"
Refs #29593, #26891 -- Doc'd RegisterLookupMixin.get_lookups().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:8>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Component: Documentation | Version: 2.1
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Ryan Verner):
Hey, did this not make it into the official documentation? I assumed that
would be automatically generated from the repo.
This isn't mentioned on this page, which is where people will generally be
looking for upgrade/depreciation advice -
https://docs.djangoproject.com/en/2.1/releases/2.1/
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:10>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Simon Charette <charette.s@…>):
In [changeset:"66c0c58cf2bc08233ca7bd1d4973e34cbc2ab2ec" 66c0c58c]:
{{{
#!CommitTicketReference repository=""
revision="66c0c58cf2bc08233ca7bd1d4973e34cbc2ab2ec"
[2.1.x] Fixed #29593 -- Added QUERY_TERMS removal to 2.1 release notes.
Removed in 244cc401559e924355cf943b6b8e66ccf2f6da3a.
Backport of 5180015051f262b73559bb55a8e3fe6f551f8b68 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:11>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Simon Charette):
Ryan, it should eventually show up. I just did the backport to the
`stable/2.1.x` branch.
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:12>
Django
Reporter: Ryan Verner | Owner: Carlton
| Gibson
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"a004350193a503b6722633c4309f70551fde0983" a0043501]:
{{{
#!CommitTicketReference repository=""
revision="a004350193a503b6722633c4309f70551fde0983"
[2.1.x] Refs #29593, #26891 -- Doc'd RegisterLookupMixin.get_lookups().
Backport of a67ebcb1cbd37e1fc9eddd2da1dda7f319c5ac1d from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29593#comment:13>