[Django] #24219: Deprecate django.forms.extras and move SelectDateWidget with the other widget.

10 views
Skip to first unread message

Django

unread,
Jan 25, 2015, 10:45:42 AM1/25/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
------------------------------------------------+------------------------
Reporter: loic | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Forms | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The content of `django.forms.extras` has hardly changed since it was
introduced and `SelectDateWidget` is its only member, let's keep all
widgets together and deprecate that package.

The `tests/forms_tests/tests/test_extra.py` has accumulated a bunch of
misplaced tests and needs cleaning up too.

--
Ticket URL: <https://code.djangoproject.com/ticket/24219>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 25, 2015, 10:54:29 AM1/25/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
-------------------------------------+-------------------------------------
Reporter: loic | Owner: loic
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by loic):

* status: new => assigned
* owner: nobody => loic
* has_patch: 0 => 1


Comment:

PR https://github.com/django/django/pull/3986.

--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:1>

Django

unread,
Jan 25, 2015, 1:19:39 PM1/25/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
--------------------------------------+------------------------------------
Reporter: loic | Owner: loic
Type: Cleanup/optimization | Status: assigned
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by charettes):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:2>

Django

unread,
Jan 26, 2015, 11:56:39 AM1/26/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
-------------------------------------+-------------------------------------
Reporter: loic | Owner: loic
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:3>

Django

unread,
Jan 27, 2015, 10:43:14 AM1/27/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
-------------------------------------+-------------------------------------
Reporter: loic | Owner: loic
Type: | Status: assigned
Cleanup/optimization |
Component: Forms | Version: master

Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Loic Bistuer <loic.bistuer@…>):

In [changeset:"3a4c9e1b43ff67b6cf4c59da757666d6ac5ce4a0"]:
{{{
#!CommitTicketReference repository=""
revision="3a4c9e1b43ff67b6cf4c59da757666d6ac5ce4a0"
Cleaned up some forms tests.

Thanks Berker Peksag and Tim Graham for the reviews. Refs #24219.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:4>

Django

unread,
Jan 27, 2015, 10:43:14 AM1/27/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
-------------------------------------+-------------------------------------
Reporter: loic | Owner: loic
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Loic Bistuer <loic.bistuer@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"728b6fd9ca8624271f072d5f4618dc3fd38e87f1"]:
{{{
#!CommitTicketReference repository=""
revision="728b6fd9ca8624271f072d5f4618dc3fd38e87f1"
Fixed #24219 -- Moved SelectDateWidget together with the other widgets
and deprecated django.forms.extras.

Thanks Berker Peksag and Tim Graham for the reviews.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:5>

Django

unread,
Jul 15, 2015, 9:58:50 AM7/15/15
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
-------------------------------------+-------------------------------------
Reporter: loic | Owner: loic
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"59c3a140eb41e0f186adf9b57029bd67beb8016a" 59c3a140]:
{{{
#!CommitTicketReference repository=""
revision="59c3a140eb41e0f186adf9b57029bd67beb8016a"
Refs #24219 -- Removed inaccurate sentence after move of SelectDateWidget.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:6>

Django

unread,
Jan 17, 2017, 10:09:51 PM1/17/17
to django-...@googlegroups.com
#24219: Deprecate django.forms.extras and move SelectDateWidget with the other
widget.
-------------------------------------+-------------------------------------
Reporter: Loic Bistuer | Owner: Loic
Type: | Bistuer
Cleanup/optimization | Status: closed
Component: Forms | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"742d666da57b52a3b00aa9b1c527ece829e95245" 742d666]:
{{{
#!CommitTicketReference repository=""
revision="742d666da57b52a3b00aa9b1c527ece829e95245"
Refs #24219 -- Removed django.forms.extras per deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/24219#comment:7>

Reply all
Reply to author
Forward
0 new messages