[Django] #24345: Sitemap tests fail because of domain mismatch
Django
----------------------------------+--------------------
Reporter: knbk | Owner: nobody
Type: Bug | Status: new
Component: contrib.sitemaps | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------+--------------------
This seems to be the result of moving the contrib tests into
`django/tests/`, it works fine on
197dd4b8f12164f6acebb3b959f9ac2040a40400. It pre-dates commit
e8cf4f8abec87b9da6ed8e5c8cf833af9b27f4dd, as the commit before that gets
the same failures. Most `sitemaps_tests` fail because the expected result
(`example.com`) and the actual response (`testserver`) have mismatching
domain names.
There's probably something wrong with the tests themselves.
--
Ticket URL: <https://code.djangoproject.com/ticket/24345>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: knbk | Owner: nobody
Type: Bug | Status: new
Component: contrib.sitemaps | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by knbk):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> This seems to be the result of moving the contrib tests into
> `django/tests/`, it works fine on
> 197dd4b8f12164f6acebb3b959f9ac2040a40400. It pre-dates commit
> e8cf4f8abec87b9da6ed8e5c8cf833af9b27f4dd, as the commit before that gets
> the same failures. Most `sitemaps_tests` fail because the expected result
> (`example.com`) and the actual response (`testserver`) have mismatching
> domain names.
>
> There's probably something wrong with the tests themselves.
New description:
This seems to be the result of moving the contrib tests into
`django/tests/`, it works fine on
197dd4b8f12164f6acebb3b959f9ac2040a40400. It pre-dates commit
e8cf4f8abec87b9da6ed8e5c8cf833af9b27f4dd, as the commit before that gets
the same failures. Most `sitemaps_tests` fail because the expected result
(`example.com`) and the actual response (`testserver`) have mismatching
domain names, but only when run with all other tests. I haven't been able
to isolate yet which exact combination of tests causes this.
There's probably something wrong with the tests themselves.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:1>
Django
Reporter: knbk | Owner: nobody
Type: Bug | Status: new
Component: contrib.sitemaps | Version: master
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
----------------------------------+------------------------------------
Changes (by timgraham):
* keywords: => 1.8-beta
* easy: 0 => 1
* stage: Unreviewed => Accepted
Comment:
I suspect a similar fix as e0b3926026984dccc86a09c0c4f32e8bec6f3fe1 will
be needed. To reproduce this: `./runtests contenttypes_tests
sitemaps_tests`
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:2>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: assigned
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
----------------------------------+------------------------------------
* owner: nobody => knbk
* status: new => assigned
* has_patch: 0 => 1
Comment:
PR: https://github.com/django/django/pull/4145
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:3>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
----------------------------------+------------------------------------
Comment (by knbk):
Yes, that fixes the issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:4>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:5>
Django
Reporter: knbk | Owner: knbk
Component: contrib.sitemaps | Version: master
Severity: Normal | Resolution: fixed
Keywords: 1.8-beta | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"f668bac9d223408627ca92b2281cf7110039510b"]:
{{{
#!CommitTicketReference repository=""
revision="f668bac9d223408627ca92b2281cf7110039510b"
Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests; refs
#11505
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:6>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: closed
Severity: Normal | Resolution: fixed
Keywords: 1.8-beta | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"bc2eb6bfef00fd8ea4395e3462366b6571f88601"]:
{{{
#!CommitTicketReference repository=""
revision="bc2eb6bfef00fd8ea4395e3462366b6571f88601"
[1.8.x] Fixed #24345 -- Isolated sitemaps_tests from contenttypes_tests;
refs #11505
Backport of f668bac9d223408627ca92b2281cf7110039510b from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24345#comment:7>