[Django] #27939: GeoDjango - map doesn't show correct point in admin
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Severity: Normal | Keywords: gis, geodjango,
Triage Stage: | map, admin
Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
Just upgraded up to 1.11 and there is bug with in with gis app - map
always displays 0,0 point in admin interface despite my object has correct
coords.
--
Ticket URL: <https://code.djangoproject.com/ticket/27939>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage:
map, admin | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* Attachment "Screenshot-2017-03-14-at-22.22.17.jpg" added.
Screenshot
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage:
map, admin | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> Just upgraded up to 1.11 and there is bug with in with gis app - map
> always displays 0,0 point in admin interface despite my object has
> correct coords.
New description:
Just upgraded up to 1.11 and there is bug in GIS app - map always displays
0,0 point in admin interface despite my object has correct coords.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Accepted
map, admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
It looks like map widget expects coordinates in the different SRID.
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Accepted
map, admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* severity: Normal => Release blocker
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Accepted
map, admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
Ah yes, the new base layer from vis.earthdata.nasa.gov is also in the 3857
projection, and not 4326 as the previous one.
Before GDAL was required, we required that the projection of the default
base layer was 4326 so that no coordinates conversion were required to
display geometries in the default SRID. Now I think we can simply set the
`OpenLayersWidget.map_srid` to 3857 to fix this issue.
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Accepted
map, admin |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Claude Paroz):
I don't have a good idea for an appropriate regression test. Any idea
welcome!
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Accepted
map, admin |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/8199 PR] based on Claude's
suggested fix. Some test failures need to be fixed -- perhaps that would
be enough for the regression test? I tested manually and it seems to work.
To reproduce in the admin, you must use `ModelAdmin` rather than
`GeoModelAdmin`.
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Accepted
map, admin |
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
Comment:
Tests are passing now.
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.11
Keywords: gis, geodjango, | Triage Stage: Ready for
map, admin | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Component: GIS | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: gis, geodjango, | Triage Stage: Ready for
map, admin | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"93eca976c15dceaf445ab4739bb2f635a2021db0" 93eca97]:
{{{
#!CommitTicketReference repository=""
revision="93eca976c15dceaf445ab4739bb2f635a2021db0"
Fixed #27939 -- Updated OpenLayersWidget.map_srid for OpenLayers 3.
Regression in 2ebfda38e65177dfc7d6e90457ffa4a0fa2796f0 (refs #25004).
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Component: GIS | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: gis, geodjango, | Triage Stage: Ready for
map, admin | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"c548dba428d8eed290846235d1aef4c92c0d7b60" c548dba4]:
{{{
#!CommitTicketReference repository=""
revision="c548dba428d8eed290846235d1aef4c92c0d7b60"
[1.11.x] Fixed #27939 -- Updated OpenLayersWidget.map_srid for OpenLayers
3.
Regression in 2ebfda38e65177dfc7d6e90457ffa4a0fa2796f0 (refs #25004).
Backport of 93eca976c15dceaf445ab4739bb2f635a2021db0 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Component: GIS | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: gis, geodjango, | Triage Stage: Ready for
map, admin | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"816c5753ac554b2af710aebc98ad60fd5823e03f" 816c5753]:
{{{
#!CommitTicketReference repository=""
revision="816c5753ac554b2af710aebc98ad60fd5823e03f"
Fixed #27965 -- Fixed precision comparison in a geoforms test (refs
#27939).
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Component: GIS | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: gis, geodjango, | Triage Stage: Ready for
map, admin | checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"4f02adbf5390187cf3a86037657a3caf53183630" 4f02adb]:
{{{
#!CommitTicketReference repository=""
revision="4f02adbf5390187cf3a86037657a3caf53183630"
[1.11.x] Fixed #27965 -- Fixed precision comparison in a geoforms test
(refs #27939).
Backport of 816c5753ac554b2af710aebc98ad60fd5823e03f from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27939#comment:12>