[Django] #28937: BinaryField enforces editable=False
Django
-------------------------------------+-------------------------------------
Reporter: James Pic | Owner: nobody
Type: New | Status: new
feature |
Component: Database | Version: 2.0
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
Currently, it's hard to make a BinaryField subclass which has an upload
widget because it hardcodes editable=False:
https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2298
Can we replace this with kwargs.setdefault('editable', False) ?
Thanks
--
Ticket URL: <https://code.djangoproject.com/ticket/28937>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: James Pic | Owner: nobody
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Unreviewed => Accepted
Comment:
Sure.
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:1>
Django
-------------------------------------+-------------------------------------
| Curry
Type: New feature | Status: assigned
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => assigned
* owner: nobody => Cameron Curry
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:2>
Django
-------------------------------------+-------------------------------------
| Curry
Type: New feature | Status: assigned
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by James Pic):
Thanks ! Note that BinaryField.deconstruct() also expects some hack with
editable, which i could circumvent it be setting def deconstruct(self):
models.Field.deconstruct(self), so, some change might be needed here too.
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:3>
Django
-------------------------------------+-------------------------------------
| Curry
Type: New feature | Status: assigned
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Cameron Curry):
Hi James could you clarify a bit what you mean? I'm planning on following
the same pattern as URLField.deconstruct and FilePathField.deconstruct in
BinaryField.deconstruct, as in:
def deconstruct:
...
if kwargs.get('editable') is False: del kwargs!['editable']
...
would this do the trick?
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:4>
Django
-------------------------------------+-------------------------------------
| Curry
Type: New feature | Status: assigned
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/9476 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:5>
Django
-------------------------------------+-------------------------------------
| Curry
Type: New feature | Status: assigned
Component: Database layer | Version: 2.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Cameron Curry):
Replying to [comment:4 Cameron Curry]:
> Hi James could you clarify a bit what you mean? I'm planning on
following the same pattern as URLField.deconstruct and
FilePathField.deconstruct in BinaryField.deconstruct, as in:
> def deconstruct:
> ...
> if kwargs.get('editable') is False: del kwargs!['editable']
> ...
>
> would this do the trick?
never mind I think I get it
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:6>
Django
-------------------------------------+-------------------------------------
| Curry
Type: New feature | Status: assigned
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* version: 2.0 => master
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: James Pic | Owner: Cameron
| Curry
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Old description:
> Currently, it's hard to make a BinaryField subclass which has an upload
> widget because it hardcodes editable=False:
> https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2298
>
> Can we replace this with kwargs.setdefault('editable', False) ?
>
> Thanks
New description:
Currently, it's hard to make a BinaryField subclass which has an upload
widget because it
[https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2298
hardcodes editable=False].
Can we replace this with `kwargs.setdefault('editable', False)` ?
Thanks
--
Comment (by Tim Graham):
I added some documentation changes to the patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:8>
Django
Reporter: James Pic | Owner: Cameron
| Curry
Component: Database layer | Version: master
(models, ORM) |
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"622ead6aaf55288cd355f22e8bb9c56d8e12556c" 622ead6]:
{{{
#!CommitTicketReference repository=""
revision="622ead6aaf55288cd355f22e8bb9c56d8e12556c"
Fixed #28937 -- Allowed BinaryField to be editable=True.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28937#comment:9>