[Django] #20907: Test failure on Oracle: test_attribute_name_not_python_keyword
Django
----------------------------------------------+--------------------
Reporter: shai | Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: 1.4
Severity: Normal | Keywords: oracle
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+--------------------
Running updated stable/1.4.x on Oracle:
{{{
FAIL: test_attribute_name_not_python_keyword
(regressiontests.inspectdb.tests.InspectDBTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/django/django/django/test/testcases.py", line 861, in
skip_wrapper
return test_func(*args, **kwargs)
File "/home/django/django/tests/regressiontests/inspectdb/tests.py",
line 17, in test_attribute_name_not_python_keyword
out.getvalue())
AssertionError: 'people_pk = models.ForeignKey(InspectdbPeople,
primary_key=True)' not found in
u"# This is an auto-generated Django...
...people_pk = models.ForeignKey(InspectdbPeople,
unique=True)\n...
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20907>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: shai | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: oracle | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
This test failure was fixed by a18e43c5bb8cb7c82c84ca1b42d847a62ac9f077 --
I'm not sure we want to backport it to 1.4.x as it's a non-trivial change?
It does seem to cherry-pick cleanly, but I haven't tried running the
entire test suite.
--
Ticket URL: <https://code.djangoproject.com/ticket/20907#comment:1>
Django
Reporter: shai | Owner: shai
Type: Bug | Status: assigned
Component: Database layer | Version: 1.4
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: oracle | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: new => assigned
* owner: nobody => shai
Comment:
Cherry-picking the whole commit just for the Oracle problem seems wrong,
as it includes fixes for all the backends.
I'll see about applying just the Oracle change.
--
Ticket URL: <https://code.djangoproject.com/ticket/20907#comment:2>
Django
Reporter: shai | Owner: shai
Component: Database layer | Version: 1.4
Severity: Normal | Triage Stage: Accepted
Keywords: oracle | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7826824aef42097e265ad5132bfbff4c64762dd7"]:
{{{
#!CommitTicketReference repository=""
revision="7826824aef42097e265ad5132bfbff4c64762dd7"
[1.4.x] Fixed #20907 - Test failure on Oracle
Backport of the Oracle-specific part of commit a18e43c5bb8cb7c82
from master. This commit made get_indexes more consistent across
backends.
Thanks Tim Graham for pointer to the commit, akaariai and ikelly
for the original commit.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/20907#comment:3>