[Django] #25610: url template tag ignores request.current_app
Django
-----------------------------+--------------------
Reporter: knbk | Owner: nobody
Type: Bug | Status: new
Component: Core (URLs) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+--------------------
The commit that removed `context.current_app`
(5e450c52aafb62b9d83c8ac08892e0b92cbec4aa) inadvertently removed the use
of `context.request.current_app` as well. The latter should remain as a
way to explicitly override the namespace that is used to reverse the url.
--
Ticket URL: <https://code.djangoproject.com/ticket/25610>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: assigned
Component: Core (URLs) | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by knbk):
* status: new => assigned
* cc: marten.knbk@… (added)
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => knbk
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25610#comment:1>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: assigned
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by knbk):
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/5481
--
Ticket URL: <https://code.djangoproject.com/ticket/25610#comment:2>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: assigned
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25610#comment:3>
Django
Reporter: knbk | Owner: knbk
Component: Core (URLs) | Version: master
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"34af2bc523321da828a02bcf8f225ec393ed75cf" 34af2bc5]:
{{{
#!CommitTicketReference repository=""
revision="34af2bc523321da828a02bcf8f225ec393ed75cf"
Fixed #25610 -- Reverted removal of request.current_app in {% url %} tag.
The deprecation removal in 5e450c52aafb62b9d83c8ac08892e0b92cbec4aa
removed too much.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25610#comment:4>
Django
Reporter: knbk | Owner: knbk
Type: Bug | Status: closed
Keywords: | Triage Stage: Ready for checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
Indeed that's what my
[https://github.com/django/django/commit/5e450c52aafb62b9d83c8ac08892e0b92cbec4aa
#diff-45fa5fdd90e8a31a18a1e55ec2f94fa3L441 original instructions] said.
Sorry, I missed that when reviewing
5e450c52aafb62b9d83c8ac08892e0b92cbec4aa.
--
Ticket URL: <https://code.djangoproject.com/ticket/25610#comment:5>