[Django] #22979: Move bug* tests
Django
------------------------------------------------+------------------------
Reporter: timo | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
`tests/bug(639|8245)` should be combined with another test app.
--
Ticket URL: <https://code.djangoproject.com/ticket/22979>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: tushar
Type: Cleanup/optimization | Status: assigned
Component: Uncategorized | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by tushar):
* owner: nobody => tushar
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/22979#comment:1>
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: tushar
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by tushar):
I propose that bug #8245 should be moved to tests.admin_checks and renamed
from test_bug_8245 to test_double_call_autodiscover. Also that bug #639 be
moved to tests.forms_tests.tests.test_extra and renamed from test_bug_639
to test_file_upload_form_save. I will write the patch, can someone confirm
that these are the appropriate changes to be made?
--
Ticket URL: <https://code.djangoproject.com/ticket/22979#comment:2>
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: tushar
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timo):
`admin_checks` is for tests related to the system checks framework so I
don't think it's a good place for that bug. I don't see any other tests
for `admin.autodiscover()`, but how about renaming the `bug8245` directory
to `admin_autodiscover`.
`forms_tests.tests.test_extra` is for testing `django.forms.extras` which
isn't applicable for bug639. Try to find a place where `FileField` is
tested with `ModelForm`.
--
Ticket URL: <https://code.djangoproject.com/ticket/22979#comment:3>
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: tushar
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by tushar):
Thanks for the help. I've submitted a pull request:
https://github.com/django/django/pull/2961.
--
Ticket URL: <https://code.djangoproject.com/ticket/22979#comment:4>
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: tushar
Component: Uncategorized | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"11181a64f947236402903deb6fa8c4df7b8bff75"]:
{{{
#!CommitTicketReference repository=""
revision="11181a64f947236402903deb6fa8c4df7b8bff75"
Fixed #22979 -- Moved bug* tests
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22979#comment:5>
Django
--------------------------------------+------------------------------------
Reporter: timo | Owner: tushar
Type: Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"df0d5ea7bc9821923c70e7bf06d3646598cf019d"]:
{{{
#!CommitTicketReference repository=""
revision="df0d5ea7bc9821923c70e7bf06d3646598cf019d"
[1.7.x] Fixed #22979 -- Moved bug* tests
Backport of 11181a64f from master.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22979#comment:6>