[Django] #21286: Fix commented out tests in serializers

Django

unread,

Oct 17, 2013, 8:19:55 PM10/17/13

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers_regress
------------------------------------------------+------------------------
Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: Core (Serialization) | Version: master
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
`tests/serializers_regress/tests.py` contains some commented out items in
the `test_data` list. I think it may be because not all serializers
support those items. If this is the case, we should make appropriate
modifications so the tests are run where they are supported and skipped
where not.

--
Ticket URL: <https://code.djangoproject.com/ticket/21286>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Oct 20, 2013, 6:12:50 AM10/20/13

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers_regress

--------------------------------------+------------------------------------

Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by bmispelon):

* cc: bmispelon@… (added)

Comment:

While looking into this, I believe I found the reason why some of the
tests are commented:
https://github.com/django/django/blob/8d6953d55c3aba04bbaf0f268499d6e405c653ff/tests/serializers_regress/models.py#L168-L170

The comment is not completely correct however because a few of the
commented out models trigger and error immediately, regardless of the
backend (`TypeError: 'primary_key' is not a valid argument for ...`).

* `FilePKData`, `ImagePKData` and `NullBooleanPKData` can be deleted
because of this.

* `DatePKData`, `DateTimePKData`, `TimePKData` and `TextPKData` might be
database-dependent (they all work under sqlite).

* Test case 51 (`FileData`) might be worth looking into a bit deeper. It
fails when uncommented and I believe it might be caused by the weird
`FileField.__eq__` implementation.

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:1>

Django

unread,

Sep 26, 2015, 9:22:03 AM9/26/15

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers_regress

--------------------------------------+------------------------------------

Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by claudep):

FileField and NULL value issue is tracked in #10244.

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:2>

Django

unread,

Jun 5, 2017, 3:37:18 PM6/5/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers_regress

--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"d02fc8dfd3622efd996c0e300e11f6c219b549b4" d02fc8d]:
{{{
#!CommitTicketReference repository=""
revision="d02fc8dfd3622efd996c0e300e11f6c219b549b4"
Refs #21286 -- Enabled serializer tests with date/datetime pk model
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:3>

Django

unread,

Sep 17, 2017, 1:30:22 PM9/17/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers_regress

--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"01c6a3e227b645e8dea97e9befecd23d1d3b8581" 01c6a3e]:
{{{
#!CommitTicketReference repository=""
revision="01c6a3e227b645e8dea97e9befecd23d1d3b8581"
Refs #21286 -- Enabled serializer tests with time pk model
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:4>

Django

unread,

Sep 17, 2017, 1:31:55 PM9/17/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------
Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Description changed by Claude Paroz:

Old description:

> `tests/serializers_regress/tests.py` contains some commented out items in
> the `test_data` list. I think it may be because not all serializers
> support those items. If this is the case, we should make appropriate
> modifications so the tests are run where they are supported and skipped
> where not.

New description:

`tests/serializers/test_data.py` contains some commented out items in the

`test_data` list. I think it may be because not all serializers support
those items. If this is the case, we should make appropriate modifications
so the tests are run where they are supported and skipped where not.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:5>

Django

unread,

Sep 17, 2017, 4:42:00 PM9/17/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------

Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by Florian Apolloner):

@claude Your latest commit caused quite a few failures, did you forget to
commit some code?

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:6>

Django

unread,

Sep 18, 2017, 3:34:06 AM9/18/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------

Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by Claude Paroz):

Argh, sorry! I was fooled by the fact the missing YAML lib in my test
virtualenv wasn't showing by a skipped ('s') test. I will revert ASAP and
try to work on that skip issue.

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:7>

Django

unread,

Sep 18, 2017, 3:36:13 AM9/18/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------

Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"256182c43d2ff029a4c55c74e43041c79d819cf6" 256182c4]:
{{{
#!CommitTicketReference repository=""
revision="256182c43d2ff029a4c55c74e43041c79d819cf6"
Revert "Refs #21286 -- Enabled serializer tests with time pk model"

This reverts commit 01c6a3e227b645e8dea97e9befecd23d1d3b8581.
Unfortunately, the YAML serializer is not yet able to cope with time
values.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:8>

Django

unread,

Sep 18, 2017, 4:09:55 AM9/18/17

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------

Reporter: Tim Graham | Owner: nobody

Type: Bug | Status: new
Component: Core (Serialization) | Version: master

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------

Comment (by Claude Paroz):

Missing skip issue in #28610.

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:9>

Django

unread,

Mar 1, 2024, 1:52:24 PM3/1/24

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------

Reporter: Tim Graham | Owner: nobody
Type: Bug | Status: new
Component: Core (Serialization) | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Adam Zapletal):

* cc: Adam Zapletal (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:10>

Django

unread,

Mar 1, 2024, 9:16:55 PM3/1/24

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
--------------------------------------+------------------------------------

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

--------------------------------------+------------------------------------
Changes (by Adam Zapletal):

* has_patch: 0 => 1

Comment:

I started looking at this ticket today to see if it was still valid and
submitted a small PR removing what I believe are some invalid, commented-
out test cases.
--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:11>

unread,

Nov 9, 2024, 10:13:08 PM11/9/24

to django-...@googlegroups.com

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Adam Zapletal):

* owner: nobody => Adam Zapletal
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:15>

Django

unread,

Nov 9, 2024, 10:38:33 PM11/9/24

to django-...@googlegroups.com

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Adam Zapletal):

* has_patch: 0 => 1

Comment:

I opened a PR uncommenting and adding a fix for `TimePKData`.
--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:16>

unread,

Nov 28, 2024, 5:45:56 AM11/28/24

to django-...@googlegroups.com

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* has_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:22>

Django

unread,

Nov 28, 2024, 9:01:11 AM11/28/24

to django-...@googlegroups.com

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Ready for checkin => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:23>

Django

unread,

Dec 2, 2024, 10:21:06 PM12/2/24

to django-...@googlegroups.com

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Adam Zapletal):

* has_patch: 0 => 1

Comment:

I opened a PR enabling the ImageField data tests in the same way that
FileField is currently tested.
--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:24>

Django

unread,

Dec 3, 2024, 3:32:58 AM12/3/24

to django-...@googlegroups.com

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:25>

Django

unread,

Dec 3, 2024, 9:15:30 AM12/3/24

to django-...@googlegroups.com

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"d2f2a6a6d5cf40ec6dffdc9a195f71bedd72acb4" d2f2a6a]:
{{{#!CommitTicketReference repository=""
revision="d2f2a6a6d5cf40ec6dffdc9a195f71bedd72acb4"
Refs #21286 -- Enabled ImageField test cases in serializer data tests.

This aligns ImageField to be tested in the same way as FileField.
The commented-out test also exists for FileField and relates to #10244.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:26>

Django

unread,

Dec 3, 2024, 9:15:47 AM12/3/24

to django-...@googlegroups.com

Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* has_patch: 1 => 0

* stage: Ready for checkin => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:27>

Django

unread,

Dec 3, 2024, 9:17:26 AM12/3/24

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Adam
| Zapletal
Type: Bug | Status: assigned
Component: Core | Version: dev
(Serialization) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Adam Zapletal):

The final commented-out tests are blocked by #10244. I'll shift my focus
to that ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:28>

Django

unread,

Dec 5, 2024, 2:51:15 AM12/5/24

to django-...@googlegroups.com

#21286: Fix commented out tests in serializers.test_data
-------------------------------------+-------------------------------------
Reporter: Tim Graham | Owner: Adam
| Zapletal
Type: Bug | Status: assigned
Component: Core | Version: dev
(Serialization) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Sarah Boyce <42296566+sarahboyce@…>):

In [changeset:"3d508ececbd3b7b652aedc66b0d3d2c7baa4795a" 3d508ec]:
{{{#!CommitTicketReference repository=""
revision="3d508ececbd3b7b652aedc66b0d3d2c7baa4795a"
Refs #21286 -- Fixed serializers tests if Pillow isn't installed.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21286#comment:29>

Reply all

Reply to author

Forward

[Django] #21286: Fix commented out tests in serializers_regress

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django

Django