[Django] #25667: Misspelling in docutils setting override
Django
-----------------------------------+--------------------
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
Should be `initial_header_level`, not `inital_header_level`.
--
Ticket URL: <https://code.djangoproject.com/ticket/25667>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
As this has been broken forever ("Imported Django from private SVN
repository") contains the misspelling, I wonder if we need to fix it (or
what change fixing it causes)?
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:1>
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by scop):
* has_patch: 0 => 1
Comment:
Frankly, I don't know the answer to either, I just happened to stumble
upon this while checking for general misspellings.
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:2>
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_tests: 0 => 1
* stage: Unreviewed => Accepted
Comment:
I think it makes sense, but we should try to add a test.
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:3>
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by scop):
* needs_tests: 1 => 0
Comment:
I took a look, and in my opinion initial header level 3 is desirable; h3
looks better than h1 there, and the page already contains a h1 (and
seemingly also a h2) and there at least used to be a general
recommendation not to have more than one h1 in web pages. PR force-updated
with a test case.
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:4>
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
Comment:
Test could use some improvement as noted on the PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:5>
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: contrib.admindocs | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by scop):
* needs_better_patch: 1 => 0
Comment:
PR force-updated
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:6>
Django
Reporter: scop | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admindocs | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"4d0f8831a7498ab3b1ebcf4cafa2ee234503e4f8" 4d0f883]:
{{{
#!CommitTicketReference repository=""
revision="4d0f8831a7498ab3b1ebcf4cafa2ee234503e4f8"
Fixed #25667 -- Fixed admindocs initial_header_level.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25667#comment:7>