Re: [Django] #13875: submit_row templatetag should pass whole context

7 views
Skip to first unread message

Django

unread,
Feb 3, 2016, 5:46:05 AM2/3/16
to django-...@googlegroups.com
#13875: submit_row templatetag should pass whole context
-------------------------------+------------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+------------------------------------

Comment (by nemesisdesign):

Just opened PR https://github.com/django/django/pull/6078.

A more paranoid test could be written, like creating a custom app with an
admin that extends the context, loads a modified version of the subimt_row
template and check the extended context is available in the template. But
I think all the complexity needed wouldn't add much value.

Federico

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:19>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 4, 2016, 10:53:45 AM2/4/16
to django-...@googlegroups.com
#13875: submit_row templatetag should pass whole context
-------------------------------------+-------------------------------------

Reporter: drul | Owner: dArignac
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:20>

Django

unread,
Feb 4, 2016, 12:00:14 PM2/4/16
to django-...@googlegroups.com
#13875: submit_row templatetag should pass whole context
-------------------------------------+-------------------------------------
Reporter: drul | Owner: dArignac
Type: New feature | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"e972a7d03d81b2b336eb430a61d7215a3e6c4763" e972a7d0]:
{{{
#!CommitTicketReference repository=""
revision="e972a7d03d81b2b336eb430a61d7215a3e6c4763"
Fixed #13875 -- Made admin's submit_row template tag pass whole context.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/13875#comment:21>

Reply all
Reply to author
Forward
0 new messages