[Django] #27531: Delete confirmation page overrides extrahead

24 views
Skip to first unread message

Django

unread,
Nov 23, 2016, 8:28:27 PM11/23/16
to django-...@googlegroups.com
#27531: Delete confirmation page overrides extrahead
-----------------------------------------+------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Both `delete_confirmation.html` and `delete_selected_confirmation.html`
templates have extrahead block which overrides any rules declared in
custom `base_site.html`

--
Ticket URL: <https://code.djangoproject.com/ticket/27531>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 23, 2016, 9:52:48 PM11/23/16
to django-...@googlegroups.com
#27531: Delete confirmation page overrides extrahead
-------------------------------+--------------------------------------

Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by elky):

* has_patch: 0 => 1


Comment:

Pushed a fix here: https://github.com/django/django/pull/7608

--
Ticket URL: <https://code.djangoproject.com/ticket/27531#comment:1>

Django

unread,
Nov 24, 2016, 6:39:26 AM11/24/16
to django-...@googlegroups.com
#27531: Delete confirmation page overrides extrahead
-------------------------------------+-------------------------------------

Reporter: elky | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/27531#comment:2>

Django

unread,
Nov 24, 2016, 6:40:32 AM11/24/16
to django-...@googlegroups.com
#27531: Delete confirmation page overrides extrahead
-------------------------------------+-------------------------------------
Reporter: elky | Owner: nobody
Type: Bug | Status: closed
Component: contrib.admin | Version: 1.10
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"9a49fdcd8f176d033dd2602825a2103ff7273af4" 9a49fdc]:
{{{
#!CommitTicketReference repository=""
revision="9a49fdcd8f176d033dd2602825a2103ff7273af4"
Fixed #27531 -- Added block.super to admin's delete confirmation extrahead
blocks.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27531#comment:3>

Reply all
Reply to author
Forward
0 new messages