Re: [Django] #6517: MySQL: manage.py dbshell does not get charset from DATABASES setting

Django

unread,

Sep 23, 2016, 10:54:46 AM9/23/16

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------
Reporter: Tom Vergote | Owner: (none)
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* status: assigned => new
* owner: Victoria Martínez de la Cruz => (none)

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:11>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

May 12, 2017, 8:43:32 AM5/12/17

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------

Reporter: Tom Vergote | Owner: Biswajit
| Sahu
Type: Bug | Status: assigned

Changes (by Biswajit Sahu):

* status: new => assigned
* owner: (none) => Biswajit Sahu

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:12>

Django

unread,

Oct 2, 2020, 7:02:20 AM10/2/20

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------

Reporter: Tom Vergote | Owner: (none)
Type: Bug | Status: new

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by felixxm):

* easy: 0 => 1

Django

unread,

Oct 2, 2020, 3:47:42 PM10/2/20

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------

Reporter: Tom Vergote | Owner: Manav
| Agarwal
Type: Bug | Status: assigned

Changes (by Manav Agarwal):

* owner: (none) => Manav Agarwal

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:13>

Django

unread,

Oct 4, 2020, 5:48:29 PM10/4/20

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------
Reporter: Tom Vergote | Owner: Manav
| Agarwal
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Manav Agarwal):

{{{
def test_charset_configured(self):
self.assertEqual(
['mysql', '--user=someuser', '--password=somepassword',
'--host=somehost', '--port=444', 'default-character-
set=utf8', 'somedbname'],
self.get_command_line_arguments({
'NAME': 'somedbname',
'USER': 'someuser',
'PASSWORD': 'somepassword',
'HOST': 'somehost',
'PORT': 444,
'DEFAULT-CHARACTER-SET' : 'utf8',
}))

}}}
Adding above mentioned function in {{{MySqlDbshellCommandTestCase}}} class
of{{{ tests/dbshell/test_mysql.py }}}would be a good test?
Please review the same so that i may create a PR

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:14>

Django

unread,

Oct 15, 2020, 2:09:31 AM10/15/20

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:16>

Django

unread,

Oct 17, 2020, 6:25:44 AM10/17/20

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------
Reporter: Tom Vergote | Owner: Manav
| Agarwal
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:17>

Django

unread,

Oct 17, 2020, 6:48:18 AM10/17/20

to django-...@googlegroups.com

#6517: MySQL: manage.py dbshell does not get charset from DATABASES setting
-------------------------------------+-------------------------------------
Reporter: Tom Vergote | Owner: Manav
| Agarwal

Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |

Severity: Normal | Resolution: fixed

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"af87574a3c3df61cf2f829909977e347118e6480" af87574a]:
{{{
#!CommitTicketReference repository=""
revision="af87574a3c3df61cf2f829909977e347118e6480"
Fixed #6517 -- Made dbshell use charset option on MySQL.

Co-Authored-By: Mariusz Felisiak <felisiak...@gmail.com>
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/6517#comment:18>

Reply all

Reply to author

Forward