[Django] #17366: Deprecate loading tests from models.py
Django
------------------------------------------------+------------------------
Reporter: Alex | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: SVN
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
This is inconsistent with pretty much every other test tool, and really
doesn't make a whole lot of sense.
--
Ticket URL: <https://code.djangoproject.com/ticket/17366>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: SVN
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by russellm):
There is a reason that models.py was searched for tests -- it's to catch
any doctests that are defined on model methods.
I'm not necessarily arguing against the decision to deprecate models.py as
a source of tests, but given that it wasn't a completely arbitrary
decision in the first place, it's worth documenting the specific
consequences.
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:1>
Django
Reporter: Alex | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by EmilStenstrom):
* component: Testing framework => Documentation
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:2>
Django
Reporter: Alex | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timo):
I don't think this should be a documentation ticket as its scope is much
larger than just that, correct?
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:3>
Django
Reporter: Alex | Owner: nobody
Type: Cleanup/optimization | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by aaugustin):
* component: Documentation => Testing framework
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:4>
Django
Reporter: Alex | Owner: jcatalan
Type: Cleanup/optimization | Status: assigned
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by jcatalan):
* owner: nobody => jcatalan
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:5>
Django
Reporter: Alex | Owner: jcatalan
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Carl Meyer <carl@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9012833af857e081b515ce760685b157638efcef"]:
{{{
#!CommitTicketReference repository=""
revision="9012833af857e081b515ce760685b157638efcef"
Fixed #17365, #17366, #18727 -- Switched to discovery test runner.
Thanks to Preston Timmons for the bulk of the work on the patch,
especially
updating Django's own test suite to comply with the requirements of the
new
runner. Thanks also to Jannis Leidel and Mahdi Yusuf for earlier work on
the
patch and the discovery runner.
Refs #11077, #17032, and #18670.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:6>
Django
Reporter: Alex | Owner: jcatalan
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Severity: Normal | Resolution: fixed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Florian Apolloner <florian@…>):
In [changeset:"e23a5f9a4730ddecb8f3950ee2936716f458c506"]:
{{{
#!CommitTicketReference repository=""
revision="e23a5f9a4730ddecb8f3950ee2936716f458c506"
Fixed a regression in the test runner loading of runtests.py.
Refs #17365, #17366, #18727.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:7>
Django
Reporter: Alex | Owner: jcatalan
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Severity: Normal | Resolution: fixed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Florian Apolloner <florian@…>):
In [changeset:"2bf403ecbd958bfb269794b36e61b69f0aede4cf"]:
{{{
#!CommitTicketReference repository=""
revision="2bf403ecbd958bfb269794b36e61b69f0aede4cf"
Fixed a regression from e23a5f9a4730ddecb8f3950ee2936716f458c506.
Excluded postgis specific gis tests from other spatial databases.
Refs #17365, #17366, #18727.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:8>
Django
Reporter: Alex | Owner: jcatalan
Type: Cleanup/optimization | Status: closed
Component: Testing framework | Version: master
Severity: Normal | Resolution: fixed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"bf5430a20b65b3e76a2f8cd2580101e0baa59f82"]:
{{{
#!CommitTicketReference repository=""
revision="bf5430a20b65b3e76a2f8cd2580101e0baa59f82"
Removed django.test.simple and django.test._doctest per deprecation
timeline.
refs #17365, #17366, #18727.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17366#comment:9>