[Django] #27661: Move FileSystemFinder ImproperlyConfigured errors to system checks
Django
------------------------------------------------+------------------------
Reporter: Jerome Leclanche | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.staticfiles | Version: 1.10
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
------------------------------------------------+------------------------
FileSystemFinder currently checks for the following on `__init__`:
- Whether STATICFILES_DIRS is a list or tuple, failing if it's not
- Whether STATICFILES_DIRS contains a directory equivalent to STATIC_ROOT
I'd like to suggest moving both of those checks to the Django system
checks framework. As it is, they happen at runtime which delays when the
error shows up.
--
Ticket URL: <https://code.djangoproject.com/ticket/27661>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Jerome Leclanche | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.staticfiles | Version: 1.10
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:1>
Django
Reporter: Jerome Leclanche | Owner: Ling-Xiao
Type: | Yang
Cleanup/optimization | Status: assigned
Component: contrib.staticfiles | Version: 1.10
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Ling-Xiao Yang):
* owner: nobody => Ling-Xiao Yang
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:2>
Django
Reporter: Jerome Leclanche | Owner: Ling-Xiao
Type: | Yang
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Ling-Xiao Yang):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/7781 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:3>
Django
Reporter: Jerome Leclanche | Owner: Ling-Xiao
Type: | Yang
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:4>
Django
Reporter: Jerome Leclanche | Owner: Ling-Xiao
Type: | Yang
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:5>
Django
Reporter: Jerome Leclanche | Owner: Ling-Xiao
Type: | Yang
Component: contrib.staticfiles | Version: 1.10
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"0ec4dc91e0e7befdd06aa0613b5d0fbe3c785ee7" 0ec4dc9]:
{{{
#!CommitTicketReference repository=""
revision="0ec4dc91e0e7befdd06aa0613b5d0fbe3c785ee7"
Fixed #27661 -- Moved FileSystemFinder's ImproperlyConfigured exceptions
to system checks.
Thanks Simon Charette, Mariusz Felisiak, Tim Graham, and Adam Johnson
for review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:6>
Django
Reporter: Jerome Leclanche | Owner: Ling-Xiao
Type: | Yang
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"b23e3a1caa10f824b6a0f8bbfaaab7fe53ac3abf" b23e3a1c]:
{{{
#!CommitTicketReference repository=""
revision="b23e3a1caa10f824b6a0f8bbfaaab7fe53ac3abf"
Refs #27661 -- Added Tags.staticfiles.
Follow up to 0ec4dc91e0e7befdd06aa0613b5d0fbe3c785ee7.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/27661#comment:7>