[Django] #25196: Wrong db name in "Destroying old test database" message

10 views
Skip to first unread message

Django

unread,
Jul 30, 2015, 7:11:25 AM7/30/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
----------------------------------------------+--------------------
Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
----------------------------------------------+--------------------
The database name to be destroyed in the "Destroying old test database"
message is incorrect.

Pull request at https://github.com/django/django/pull/5068

The oracle backend needs a fix too, it also outputs an incorrect db name
but the problems in it don't apparently end there as there is some
confusion in the messages where it says it's deleting a database but
actually deletes a tablespace. So I'll leave fixing that to someone who
actually knows what it's doing and can test it.

--
Ticket URL: <https://code.djangoproject.com/ticket/25196>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 30, 2015, 10:56:10 AM7/30/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------

Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:1>

Django

unread,
Aug 1, 2015, 8:06:24 AM8/1/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------

Reporter: scop | Owner: nobody
Type: Bug | Status: new
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:2>

Django

unread,
Sep 16, 2015, 12:43:00 PM9/16/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: darkryder
Type: Bug | Status: assigned

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by darkryder):

* owner: nobody => darkryder
* status: new => assigned


Comment:

Taking it since it's getting stale.

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:3>

Django

unread,
Sep 16, 2015, 2:42:47 PM9/16/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: darkryder
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by darkryder):

* needs_better_patch: 1 => 0


Comment:

PR: https://github.com/django/django/pull/5298

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:4>

Django

unread,
Sep 16, 2015, 8:02:11 PM9/16/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: darkryder
Type: Bug | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1


Comment:

The new pull request isn't correct.

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:5>

Django

unread,
Sep 17, 2015, 10:32:09 AM9/17/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner:
Type: Bug | Status: new

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by darkryder):

* status: assigned => new


* needs_better_patch: 1 => 0

* has_patch: 1 => 0
* owner: darkryder =>


Comment:

Removing self.

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:6>

Django

unread,
Sep 18, 2015, 3:26:23 AM9/18/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner:
Type: Bug | Status: new

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by scop):

* has_patch: 0 => 1


Comment:

PR 5068 updated

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:7>

Django

unread,
Sep 25, 2015, 10:22:37 AM9/25/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: Tim
| Graham <timograham@…>
Type: Bug | Status: closed

Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* owner: => Tim Graham <timograham@…>
* resolution: => fixed


Comment:

In [changeset:"afe777639cc1c591df32591e196d4cda5783c615" afe7776]:
{{{
#!CommitTicketReference repository=""
revision="afe777639cc1c591df32591e196d4cda5783c615"
Fixed #25196 -- Normalized database representations in test database
messages.

Left over Oracle mostly as-is since it's more complicated.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:8>

Django

unread,
Sep 25, 2015, 10:41:19 AM9/25/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: Tim
| Graham <timograham@…>
Type: Bug | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"50ccedae98742ae0d9dfb5d7c268ee2e2a096e34" 50ccedae]:
{{{
#!CommitTicketReference repository=""
revision="50ccedae98742ae0d9dfb5d7c268ee2e2a096e34"
[1.9.x] Fixed #25196 -- Normalized database representations in test
database messages.

Left over Oracle mostly as-is since it's more complicated.

Backport of afe777639cc1c591df32591e196d4cda5783c615 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:9>

Django

unread,
Nov 13, 2015, 11:30:27 AM11/13/15
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: Tim
| Graham <timograham@…>
Type: Bug | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"abcdb237bb313d116ce2ac8e90f79f61429afc70" abcdb23]:
{{{
#!CommitTicketReference repository=""
revision="abcdb237bb313d116ce2ac8e90f79f61429afc70"
Refs #25196 -- Fixed incorrect argument order in test database creation.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:10>

Django

unread,
Jan 19, 2016, 7:09:11 AM1/19/16
to django-...@googlegroups.com
#25196: Wrong db name in "Destroying old test database" message
-------------------------------------+-------------------------------------
Reporter: scop | Owner: Tim
| Graham <timograham@…>
Type: Bug | Status: closed
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"f0da306af186c121c0e339342f60d29552bf8c1a" f0da306]:
{{{
#!CommitTicketReference repository=""
revision="f0da306af186c121c0e339342f60d29552bf8c1a"
[1.9.x] Fixed #26096, refs #25196 -- Fixed incorrect argument order in
test database creation.

Backport of abcdb237bb313d116ce2ac8e90f79f61429afc70 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25196#comment:11>

Reply all
Reply to author
Forward
0 new messages