[Django] #24682: generic editing views pointing to wrong method
Django
-------------------------------+--------------------
Reporter: speg | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
The form_valid method of [https://docs.djangoproject.com/en/1.8/ref/class-
based-views/flattened-index/#createview CreateView] is pointing
[https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
editing/#django.views.generic.edit.FormMixin.form_valid here]. This is
FormMixin, however I believe it should be point
[https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
editing/#django.views.generic.edit.ModelFormMixin.form_valid here], the
ModelFormMixin implementation of is_valid.
--
Ticket URL: <https://code.djangoproject.com/ticket/24682>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by speg):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Old description:
> The form_valid method of [https://docs.djangoproject.com/en/1.8/ref
> /class-based-views/flattened-index/#createview CreateView] is pointing
> [https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
> editing/#django.views.generic.edit.FormMixin.form_valid here]. This is
> FormMixin, however I believe it should be point
> [https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
> editing/#django.views.generic.edit.ModelFormMixin.form_valid here], the
> ModelFormMixin implementation of is_valid.
New description:
The form_valid method of [https://docs.djangoproject.com/en/1.8/ref/class-
based-views/flattened-index/#createview CreateView] is pointing
[https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
editing/#django.views.generic.edit.FormMixin.form_valid here]. This is
FormMixin, however I believe it should be point
[https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
editing/#django.views.generic.edit.ModelFormMixin.form_valid here], the
ModelFormMixin implementation of form_valid.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:1>
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Description changed by speg:
Old description:
> The form_valid method of [https://docs.djangoproject.com/en/1.8/ref
> /class-based-views/flattened-index/#createview CreateView] is pointing
> [https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
> editing/#django.views.generic.edit.FormMixin.form_valid here]. This is
> FormMixin, however I believe it should be point
> [https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
> editing/#django.views.generic.edit.ModelFormMixin.form_valid here], the
> ModelFormMixin implementation of form_valid.
New description:
The form_valid method of [https://docs.djangoproject.com/en/1.8/ref/class-
based-views/flattened-index/#createview CreateView] is pointing
[https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
editing/#django.views.generic.edit.FormMixin.form_valid here]. This is
FormMixin, however I believe it should be point
[https://docs.djangoproject.com/en/1.8/ref/class-based-views/mixins-
editing/#django.views.generic.edit.ModelFormMixin.form_valid here], the
ModelFormMixin implementation of form_valid.
The same applies to UpdateView.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:2>
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:3>
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by speg):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:4>
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by speg):
See PR: https://github.com/django/django/pull/4542
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:5>
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"258d81acbee252693569e3d4e5f95d3dfe3b0638" 258d81a]:
{{{
#!CommitTicketReference repository=""
revision="258d81acbee252693569e3d4e5f95d3dfe3b0638"
Fixed #24682 -- Corrected a few generic editing view links
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:6>
Django
Reporter: speg | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"2329ca969f81309bd3d15da55f25f8e1bee3122d" 2329ca9]:
{{{
#!CommitTicketReference repository=""
revision="2329ca969f81309bd3d15da55f25f8e1bee3122d"
[1.8.x] Fixed #24682 -- Corrected a few generic editing view links
Backport of 258d81acbee252693569e3d4e5f95d3dfe3b0638 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24682#comment:7>