[Django] #22715: Failing tests on Oracle/Python 3
Django
-------------------------------------------+----------------------------
Reporter: timo | Owner: nobody
Type: Bug | Status: new
Component: Python 3 | Version: 1.7-beta-2
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+----------------------------
cx_Oracle 5.1.3 includes fixes the segfaults encountered with Python 3.
There are some failing migrations tests, all of which but 1 are resolved
with the attached patch.
Failing test:
{{{
======================================================================
ERROR: test_add_binaryfield (migrations.test_operations.OperationTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tim/code/django/django/db/backends/utils.py", line 63, in
execute
return self.cursor.execute(sql, params)
File "/home/tim/code/django/django/db/backends/oracle/base.py", line
890, in execute
return self.cursor.execute(query, self._param_generator(params))
cx_Oracle.DatabaseError: ORA-00984: column not allowed here
The above exception was the direct cause of the following exception:
Traceback (most recent call last):
File "/home/tim/code/django/django/test/testcases.py", line 950, in
skip_wrapper
return test_func(*args, **kwargs)
File "/home/tim/code/django/tests/migrations/test_operations.py", line
458, in test_add_binaryfield
models.BinaryField(default=b'"\'"'),
File "/home/tim/code/django/tests/migrations/test_operations.py", line
32, in apply_operations
return migration.apply(project_state, editor)
File "/home/tim/code/django/django/db/migrations/migration.py", line
107, in apply
operation.database_forwards(self.app_label, schema_editor,
project_state, new_state)
File "/home/tim/code/django/django/db/migrations/operations/fields.py",
line 38, in database_forwards
field,
File "/home/tim/code/django/django/db/backends/schema.py", line 406, in
add_field
self.execute(sql, params)
File "/home/tim/code/django/django/db/backends/schema.py", line 98, in
execute
cursor.execute(sql, params)
File "/home/tim/code/django/django/db/backends/utils.py", line 63, in
execute
return self.cursor.execute(sql, params)
File "/home/tim/code/django/django/db/utils.py", line 94, in __exit__
six.reraise(dj_exc_type, dj_exc_value, traceback)
File "/home/tim/code/django/django/utils/six.py", line 549, in reraise
raise value.with_traceback(tb)
File "/home/tim/code/django/django/db/backends/utils.py", line 63, in
execute
return self.cursor.execute(sql, params)
File "/home/tim/code/django/django/db/backends/oracle/base.py", line
890, in execute
return self.cursor.execute(query, self._param_generator(params))
django.db.utils.DatabaseError: ORA-00984: column not allowed here
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22715>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: timo | Owner: shai
Type: Bug | Status: assigned
Component: Python 3 | Version: 1.7-beta-2
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by shai):
* owner: nobody => shai
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/22715#comment:1>
Django
Reporter: timo | Owner: shai
Component: Python 3 | Version: 1.7-beta-2
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Shai Berger <shai@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"fd427f1fe3c563d5fe0badfec0a39d6cd43454da"]:
{{{
#!CommitTicketReference repository=""
revision="fd427f1fe3c563d5fe0badfec0a39d6cd43454da"
Fixed #22715: Corrected sql for defaults of BinaryField on Oracle with
Python3
While at it, fixed a problem in returning empty values
(still with BinaryField/Oracle/Python3).
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22715#comment:2>
Django
Reporter: timo | Owner: shai
Type: Bug | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Shai Berger <shai@…>):
In [changeset:"5f135e6a0b77e76649aac48434740cc703e843ff"]:
{{{
#!CommitTicketReference repository=""
revision="5f135e6a0b77e76649aac48434740cc703e843ff"
[1.7.x] Fixed #22715: Corrected sql for defaults of BinaryField on Oracle
with Python3
While at it, fixed a problem in returning empty values
(still with BinaryField/Oracle/Python3).
Backport of fd427f1 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22715#comment:3>
Django
Reporter: timo | Owner: shai
Type: Bug | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"06c0e740a41f64a49a11569e76edee7be04770e0"]:
{{{
#!CommitTicketReference repository=""
revision="06c0e740a41f64a49a11569e76edee7be04770e0"
Added django.utils.six.buffer_types
and used it in the Oracle SchemaEditor. Refs #22715.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22715#comment:4>
Django
Reporter: timo | Owner: shai
Type: Bug | Status: closed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"1cb5dfe05f4e8363a7cf39d400e328f4b1c33366"]:
{{{
#!CommitTicketReference repository=""
revision="1cb5dfe05f4e8363a7cf39d400e328f4b1c33366"
[1.7.x] Added django.utils.six.buffer_types
and used it in the Oracle SchemaEditor. Refs #22715.
Backport of 06c0e740a4 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22715#comment:5>