[Django] #33251: Breaking change missing from Django 4.0 changelog

10 views
Skip to first unread message

Django

unread,
Oct 31, 2021, 9:18:57 AM10/31/21
to django-...@googlegroups.com
#33251: Breaking change missing from Django 4.0 changelog
-----------------------------------------+------------------------
Reporter: Dylan Verheul | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
This commit b9e872b59329393f615c440c54f632a49ab05b78 changes the behavior
of RadioSelect. It caused tests to fail in the django-bootstrap5 package
when testing against Django main branch and Django 4.0.b1. The tests
failed because a `for=XXX` was unexpectedly not generated. I couldn't find
the change in the changelog, but I could find the change in the source
code (see commit link).

--
Ticket URL: <https://code.djangoproject.com/ticket/33251>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 31, 2021, 9:22:40 AM10/31/21
to django-...@googlegroups.com
#33251: Breaking change missing from Django 4.0 changelog
-------------------------------+--------------------------------------

Reporter: Dylan Verheul | Owner: nobody
Type: Uncategorized | Status: new
Component: Forms | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Description changed by Dylan Verheul:

Old description:

> This commit b9e872b59329393f615c440c54f632a49ab05b78 changes the behavior
> of RadioSelect. It caused tests to fail in the django-bootstrap5 package
> when testing against Django main branch and Django 4.0.b1. The tests
> failed because a `for=XXX` was unexpectedly not generated. I couldn't
> find the change in the changelog, but I could find the change in the
> source code (see commit link).

New description:

This commit b9e872b59329393f615c440c54f632a49ab05b78 changes the behavior
of RadioSelect. It caused tests to fail in the django-bootstrap5 package
when testing against Django main branch and Django 4.0.b1. The tests

failed because a `for=XXX` was unexpectedly not generated in the label
tag. I couldn't find the change in the changelog, but I could find the


change in the source code (see commit link).

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33251#comment:1>

Django

unread,
Nov 1, 2021, 12:50:33 AM11/1/21
to django-...@googlegroups.com
#33251: RadioSelect HTML change is missing in Django 4.0 changelog.
-------------------------------------+-------------------------------------

Reporter: Dylan Verheul | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Forms | Version: 4.0
Severity: Normal | Resolution: invalid

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* type: Uncategorized => Cleanup/optimization
* resolution: => invalid


Comment:

Thanks for this report, however b9e872b59329393f615c440c54f632a49ab05b78
was a bug fix and we don't add release notes for bug fixes.

Moreover the way how Django builds HTML is an implementation detail not
something Django should guarantee and all bug fixes are backwards
incompatible by nature.

--
Ticket URL: <https://code.djangoproject.com/ticket/33251#comment:2>

Reply all
Reply to author
Forward
0 new messages