[Django] #19869: Add ability to restart LiveServerThread inside a test method
Django
-----------------------------------+--------------------
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
I was trying to make a selenium test to work with different locales in one
test, like this:
{{{
for locale in locale_list:
with translation.override(locale):
self.selenium.get(something)
...test something...
}}}
But translation.override had affected only current thread, not
LiveServerThread, probably because active translation is thread-local.
Because I see no way to force LiveServerThread copy or share same thread-
local state, it would be cool if I could have ability to stop
LiveServerThread and recreate it in such cases. Currently it is
started/stopped in setUpClass/tearDownClass which means that it is created
once per TestCase run and shared between all the runs of all the test
methods.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Can you set the Accept-Language header in the request, or use your
website's "change language" feature?
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:1>
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by void):
Selenium does not let you set custom request headers:
http://code.google.com/p/selenium/issues/detail?id=141.
I am actually trying to test django admin, it have no such "change
language" feature.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:2>
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by julien):
* stage: Unreviewed => Accepted
Comment:
I think one good way of doing this is to add a new method
"`activate_live_server_locale(self, locale)`" to `LiveServerTestCase` that
would activate the locale in the separate thread. It would be even better
if it could work as a context manager like so:
{{{#!python
class MyTests(LiveServerTestcase):
def test_something(self):
with self.activate_live_server_locale('de'):
...
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:3>
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by julien):
By the way, "activate_live_server_locale" is a bit of a mouthful, so
suggestions for beter names are welcome ;)
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:4>
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by unaizalakain):
How would you modify the thread local of the live server thread from the
main thread?
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:5>
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by void):
With some kind of message or signal, I think
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:6>
Django
Reporter: void | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by unaizalakain):
I believe (though I may be wrong) that signals don't work across threads.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:7>
Django
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 0 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by unaizalakain):
* owner: nobody => unaizalakain
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 0 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* has_patch: 0 => 1
Comment:
PR sent: https://github.com/django/django/pull/2021
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by unaizalakain):
The ``set_language`` view could be used to change the live test server
thread language but that would mean adding some kind of new method to the
test case and the inability to use the already defined methods
(`django.utils.translation.override`, `django.utils.translation.activate`,
etc).
Instead, the PR opts for making the thread local that holds the current
active language a non-local. This is done in the two threads so suddenly
one thread is capable of accessing the other one's active language. This
is afterwards reverted to thread locals again.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
* cc: apollo13 (added)
Comment:
I'd very much prefer a method which just sets the active language in the
other thread as suggested by julien. While the PR might work, it makes me
run away in fear.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by unaizalakain):
Well, it surely isn't the most elegant way of doing it but defining some
special functions for changing the active language when those functions
already exist doesn't seem right to me either.
I think disabling the language thread-local in the testing environment
isn't too bad, after all, it's not needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: void | Owner:
Type: New feature | unaizalakain
Component: Testing framework | Status: assigned
Severity: Normal | Version: master
Keywords: | Resolution:
Has patch: 1 | Triage Stage: Accepted
Needs tests: 0 | Needs documentation: 0
| UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timo):
* needs_better_patch: 0 => 1
Comment:
If the patch makes apollo13 run, I guess it needs improvement. :-)
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:14>
Django
Reporter: void | Owner:
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by unaizalakain):
* status: assigned => new
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* owner: unaizalakain =>
Comment:
Then more than an improvement, I think a totally different patch is
needed, although I don't understand the need for a language thread-local
in a testing environment that doesn't support multithreading.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:15>
Django
-----------------------------------+------------------------------------
Type: New feature | Status: assigned
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by gchp):
* owner: => gchp
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:16>
Django
-----------------------------------+------------------------------------
Reporter: void | Owner: gchp
Type: New feature | Status: assigned
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by void):
The initial goal of this ticket was to deal with issue that emerged while
working on the #18767.
That is, translation.override was not able to change thread-local state of
`LiveServerThread`, and it rendered everything in one language.
#18767 ticket is fixed now and thread-local issue resolved by introducing
settings_changed signal and its receivers, in particular to the
`trans_real._active = threading.local()` line in `django.test.signals`.
Therefore, I think it's safe to close this ticket as wontfix.
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:17>
Django
-----------------------------------+------------------------------------
Reporter: void | Owner: gchp
Component: Testing framework | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by void):
* status: assigned => closed
* resolution: => wontfix
--
Ticket URL: <https://code.djangoproject.com/ticket/19869#comment:18>