[Django] #30146: Move fieldset toggle to the right
Django
------------------------------------------------+------------------------
Reporter: Pascal Polleunus | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
------------------------------------------------+------------------------
Basically…
In
[https://github.com/django/django/blob/master/django/contrib/admin/static/admin/js/collapse.js
collapse.js], remove lines 28 and 30.
In
[https://github.com/django/django/blob/master/django/contrib/admin/static/admin/css/forms.css
forms.css], for `fieldset .collapse-toggle`, add `float: right;` after
line 233.
--
Ticket URL: <https://code.djangoproject.com/ticket/30146>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Pascal Polleunus | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):
* has_patch: 1 => 0
* easy: 1 => 0
Comment:
Can you explain the why? Some screenshots would be useful.
--
Ticket URL: <https://code.djangoproject.com/ticket/30146#comment:1>
Django
Reporter: Pascal Polleunus | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* Attachment "admin-toggle-proposal.png" added.
Django
Reporter: Pascal Polleunus | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Comment (by Pascal Polleunus):
I think that from a UX point of view, the expand/collapse toggle is better
located on the right… and usually is.
The text "show/hide" could also be replaced with "+/-" or "▼/▲).
PS: Sorry, I initially planned to submit a patch but then didn't ;-)
--
Ticket URL: <https://code.djangoproject.com/ticket/30146#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Pascal Polleunus | Owner: nobody
Cleanup/optimization |
Component: contrib.admin | Version: master
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => wontfix
Comment:
I think there would be some debate on this. I prefer the current design
because you don't have to move your mouse to the right side of the screen
to do the toggling. You could write to the DevelopersMailingList to get
other opinions.
--
Ticket URL: <https://code.djangoproject.com/ticket/30146#comment:3>