[Django] #21665: assertRedirects should treat equivalent URLs differing only in URL-escaping as equal
Django
as equal
-------------------------------+--------------------
Reporter: pdc | Owner: nobody
Type: Bug | Status: new
Component: Uncategorized | Version: 1.6
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
After upgrading to Django 1.6 I get this error message while testing:
{{{
AssertionError: Response redirected to
'http://testserver/front%3Bskip%3D47', expected
'http://testserver/front;skip=47'
}}}
Given that these both represent the same URL – don’t they? – I would have
expected the assertRedirects predicate to be satisfied.
--
Ticket URL: <https://code.djangoproject.com/ticket/21665>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
as equal
Reporter: pdc | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* needs_better_patch: => 0
* component: Uncategorized => Testing framework
* needs_tests: => 0
* needs_docs: => 0
Comment:
What version did you upgrade from? If you could identify the commit where
the behavior changed, that will help us determine if this was an
intentional change or a regression that should be fixed.
--
Ticket URL: <https://code.djangoproject.com/ticket/21665#comment:1>
Django
as equal
Reporter: pdc | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by aaugustin):
This could be a consequence of #13260. See also #22223.
--
Ticket URL: <https://code.djangoproject.com/ticket/21665#comment:2>
Django
as equal
Reporter: pdc | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.6
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by aaugustin):
* type: Bug => Cleanup/optimization
* component: Testing framework => Documentation
* stage: Unreviewed => Accepted
Comment:
This particular consequence could be mentioned in the
[https://docs.djangoproject.com/en/dev/releases/1.6/#quoting-in-reverse
release notes] but I think the code is now mostly correct.
--
Ticket URL: <https://code.djangoproject.com/ticket/21665#comment:3>
Django
as equal
Reporter: pdc | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.6
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"7af32bca38f01dc5b677a4161bf0853149f97b3e"]:
{{{
#!CommitTicketReference repository=""
revision="7af32bca38f01dc5b677a4161bf0853149f97b3e"
[1.6.x] Fixed #21665 -- Documented that changes in assertRedirects may be
required given new URL escaping behavior.
Thank pdc for the report.
Backport of 62e81bc00b from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21665#comment:4>
Django
as equal
Reporter: pdc | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: 1.6
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"68a80166cd2a7e36d077a550468d382f443a079e"]:
{{{
#!CommitTicketReference repository=""
revision="68a80166cd2a7e36d077a550468d382f443a079e"
[1.7.x] Fixed #21665 -- Documented that changes in assertRedirects may be
required given new URL escaping behavior.
Thank pdc for the report.
Backport of 62e81bc00b from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/21665#comment:5>