[Django] #22894: make admin add related behaviour customizable
Django
--------------------------------------+--------------------
Reporter: rm_ | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 1
--------------------------------------+--------------------
Decouple behaviour and style from the RelatedFieldWidgetWrapper widget so
it's easier to customize.
This makes life easier for people that want to say use a modal or just
style it differently.
While at it in change_form.html start consolidating document ready event
listeners in one place.
--
Ticket URL: <https://code.djangoproject.com/ticket/22894>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: rm_ | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by rm_):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Pull request here https://github.com/django/django/pull/2847
--
Ticket URL: <https://code.djangoproject.com/ticket/22894#comment:1>
Django
Reporter: rm_ | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by rm_):
If change looks ok i've done the same for raw_id_fields widget and unified
common js code here
https://github.com/xrmx/django/commits/morepopupcleanup
--
Ticket URL: <https://code.djangoproject.com/ticket/22894#comment:2>
Django
Reporter: rm_ | Owner: nobody
Type: | Status: new
Cleanup/optimization | Version: master
Component: contrib.admin | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Comment (by timo):
Yes, please add it to the PR and I'll add some comments.
--
Ticket URL: <https://code.djangoproject.com/ticket/22894#comment:3>
Django
Reporter: rm_ | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by timo):
* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/22894#comment:4>
Django
Reporter: rm_ | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by rm_):
Thanks for the review Tim, pull requests updated with these changes:
- added title to <a>
- splitted css blocks
- renamed template block
- splitted long lines in tests
--
Ticket URL: <https://code.djangoproject.com/ticket/22894#comment:5>
Django
Reporter: rm_ | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"68c9a72e29c929d896a25b3a0f566c09b6723dd4"]:
{{{
#!CommitTicketReference repository=""
revision="68c9a72e29c929d896a25b3a0f566c09b6723dd4"
Fixed #22894 -- Made admin add related/raw ID fields widgets customizable.
Decoupled behavior and style from the RelatedFieldWidgetWrapper and
ForeignKeyRawIdWidget.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22894#comment:6>