[Django] #30764: Ignore node_modules by default for makemessages

2 views
Skip to first unread message

Django

unread,
Sep 5, 2019, 11:45:29 AM9/5/19
to django-...@googlegroups.com
#30764: Ignore node_modules by default for makemessages
------------------------------------------------+------------------------
Reporter: Anthony Ricaud | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Uncategorized | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
I think most projects never want to translate content found in
`node_modules`. This directory usually has a lot of files so it would be a
performance improvement to ignore them by default.

{{{#!shell
➜ time ./manage.py makemessages -v3|wc -l
1.49 real 1.20 user 0.27 sys
15285
➜ time ./manage.py makemessages -v3 --ignore=node_modules|wc -l
1.00 real 0.86 user 0.14 sys
378
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30764>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Sep 5, 2019, 12:11:24 PM9/5/19
to django-...@googlegroups.com
#30764: Ignore node_modules by default for makemessages
-------------------------------------+-------------------------------------

Reporter: Anthony Ricaud | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Uncategorized | Version: master
Severity: Normal | Resolution: wontfix

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz):

* status: new => closed
* resolution: => wontfix


Comment:

Sorry, but this is too specific to be included for everyone. You can
override the default `makemessages` command for your project to hard-code
this exclude.

--
Ticket URL: <https://code.djangoproject.com/ticket/30764#comment:1>

Reply all
Reply to author
Forward
0 new messages