--
Ticket URL: <https://code.djangoproject.com/ticket/17962>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
* needs_better_patch: => 0
* component: Uncategorized => contrib.admin
* needs_tests: => 1
* needs_docs: => 1
* type: Uncategorized => New feature
* stage: Unreviewed => Accepted
Comment:
I'm accepting, but marking as 'needs tests', because although it is a
simple change, we need tests that check that
`ModelAdmin.get_deleted_objects()` is actually used. This has been our
policy with other simple changes, like #14206 for
`ModelAdmin.get_list_display`, and `ListView.get_paginator`.
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:1>
* owner: nobody => Becky Smith
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:2>
* needs_docs: 1 => 0
* needs_tests: 1 => 0
Comment:
I have added PR [https://github.com/django/django/pull/8267 #8267] to
update the previously submitted patch and use the new ModelAdmin method in
the default `delete_selected` action as well as `delete_view`.
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:3>
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:4>
* needs_better_patch: 0 => 1
Comment:
I left comments for improvement on the PR. Please uncheck "Patch needs
improvement" after updating.
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:5>
* cc: Rebecca Smith (added)
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:6>
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:7>
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:8>
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:9>
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"8116e588dbdd17171a322da589b691bdf01f7041" 8116e588]:
{{{
#!CommitTicketReference repository=""
revision="8116e588dbdd17171a322da589b691bdf01f7041"
Fixed #17962 -- Added ModelAdmin.get_deleted_objects().
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/17962#comment:10>