[Django] #30175: Broken django 1.11.19 release for python2.7
Django
-------------------------------------------+------------------------
Reporter: rm_ | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
It looks like the distributed django 1.11.19 release does not match the
code in 1.11.19 tag.
Got this while running my test suite:
```
File "/usr/local/lib/python2.7/site-packages/django/template/base.py",
line 184, in __init__
engine = Engine.get_default()
File "/usr/local/lib/python2.7/site-packages/django/utils/lru_cache.py",
line 124, in wrapper
result = user_function(*args, **kwds)
File "/usr/local/lib/python2.7/site-packages/django/template/engine.py",
line 76, in get_default
django_engines = [engine for engine in engines.all()
File "/usr/local/lib/python2.7/site-packages/django/template/utils.py",
line 89, in all
return [self[alias] for alias in self]
File "/usr/local/lib/python2.7/site-packages/django/template/utils.py",
line 80, in __getitem__
engine = engine_cls(params)
File "/usr/local/lib/python2.7/site-
packages/django/template/backends/django.py", line 30, in __init__
options['libraries'] = self.get_templatetag_libraries(libraries)
File "/usr/local/lib/python2.7/site-
packages/django/template/backends/django.py", line 48, in
get_templatetag_libraries
libraries = get_installed_libraries()
File "/usr/local/lib/python2.7/site-
packages/django/template/backends/django.py", line 113, in
get_installed_libraries
for name in get_package_libraries(pkg):
File "/usr/local/lib/python2.7/site-
packages/django/template/backends/django.py", line 130, in
get_package_libraries
"trying to load '%s': %s" % (entry[1], e)
InvalidTemplateLibrary: Invalid template library specified. ImportError
raised when trying to load 'django.contrib.admin.templatetags.base':
cannot import name getfullargspec
```
But 1.11.19 tag on github does not have that file:
```
~/src/django/django/contrib/admin/templatetags$ ls -ltrh *py
-rw-r--r-- 1 rm rm 0 dic 7 2015 __init__.py
-rw-r--r-- 1 rm rm 2,1K feb 11 12:57 log.py
-rw-r--r-- 1 rm rm 1,8K feb 11 12:57 admin_urls.py
-rw-r--r-- 1 rm rm 304 feb 11 12:57 admin_static.py
-rw-r--r-- 1 rm rm 3,0K feb 11 12:57 admin_modify.py
-rw-r--r-- 1 rm rm 18K feb 11 12:57 admin_list.py
```
Downloading and unzipping:
https://files.pythonhosted.org/packages/61/28/1d3920e4d1d50b19bc5d24398a7cd85cc7b9a75a490570d5a30c57622d34/pytz-2018.9-py2.py3
-none-any.whl
There's a `django.contrib.admin.templatetags.base` that is not in git:
```
$ django/contrib/admin/templatetags$ ls -ltrh *py
-rw-r--r-- 1 rm rm 0 gen 1 2014 __init__.py
-rw-r--r-- 1 rm rm 1,3K feb 11 10:17 base.py
-rw-r--r-- 1 rm rm 304 feb 11 10:28 admin_static.py
-rw-r--r-- 1 rm rm 2,1K feb 11 10:30 log.py
-rw-r--r-- 1 rm rm 1,8K feb 11 10:30 admin_urls.py
-rw-r--r-- 1 rm rm 3,0K feb 11 10:30 admin_modify.py
-rw-r--r-- 1 rm rm 18K feb 11 10:30 admin_list.py
```
--
Ticket URL: <https://code.djangoproject.com/ticket/30175>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: rm_ | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by rm_:
Old description:
New description:
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:1>
Django
Reporter: rm_ | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.11
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by rm_:
Old description:
> It looks like the distributed django 1.11.19 release does not match the
New description:
Downloading and unzipping:
https://files.pythonhosted.org/packages/6b/2a/6625366e0e26fcc638c76d1a8b63d8d24a99d129cfebf8b101aaab0327fd/Django-1.11.19-py2.py3
-none-any.whl
There's a `django.contrib.admin.templatetags.base` that is not in git:
{{{
$ django/contrib/admin/templatetags$ ls -ltrh *py
-rw-r--r-- 1 rm rm 0 gen 1 2014 __init__.py
-rw-r--r-- 1 rm rm 1,3K feb 11 10:17 base.py
-rw-r--r-- 1 rm rm 304 feb 11 10:28 admin_static.py
-rw-r--r-- 1 rm rm 2,1K feb 11 10:30 log.py
-rw-r--r-- 1 rm rm 1,8K feb 11 10:30 admin_urls.py
-rw-r--r-- 1 rm rm 3,0K feb 11 10:30 admin_modify.py
-rw-r--r-- 1 rm rm 18K feb 11 10:30 admin_list.py
}}}
--
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:2>
Django
Reporter: rm_ | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* type: Uncategorized => Bug
* component: Uncategorized => Core (Other)
* stage: Unreviewed => Accepted
Comment:
It appears there was an error in packaging the release.
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:3>
Django
Reporter: rm_ | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
Yes. I can't currently account for the issue. Commits and tags look OK, as
does repository status when checking out those tags. I will verify and re-
issue where needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:4>
Django
Reporter: rm_ | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Patrick Cloke):
* cc: Patrick Cloke (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:5>
Django
files
---------------------------------+------------------------------------
Reporter: rm_ | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:6>
Django
files
---------------------------------+------------------------------------
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Giovanni Totaro - aka Vanni):
Probably related anomaly --> After updating Django from 2.1.5 to 2.1.6 via
pip3 I get:
{{{
./manage.py makemigrations
Migrations for 'auth':
/home/---/venvs/---/lib/python3.5/site-
packages/django/contrib/auth/migrations/0012_auto_20190211_1508.py
- Alter field name on group
}}}
{{{
cat /home/---/venvs/---/lib/python3.5/site-
packages/django/contrib/auth/migrations/0012_auto_20190211_1520.py
}}}
{{{
# Generated by Django 2.1.6 on 2019-02-11 14:20
from django.db import migrations, models
class Migration(migrations.Migration):
dependencies = [
('auth', '0011_update_proxy_permissions'),
]
operations = [
migrations.AlterField(
model_name='group',
name='name',
field=models.CharField(max_length=80, unique=True,
verbose_name='name'),
),
]
}}}
but
[https://github.com/django/django/commit/e81955401885a93a459bcc130642b6ea5bf4ba4d
#diff-49fc6cea24d46bdb27339c1aab392e32L111 commit Fixed #29939 --
Increased Group.name max_length to 150 characters] has 2.2.x tags, and pip
version has max_length=80 in django/contrib/auth/models.py:111
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:7>
Django
files
---------------------------------+------------------------------------
Type: Bug | Status: new
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson):
Hi Giovanni. Yes. Hold off for now. New releases coming.
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:8>
Django
files
Reporter: rm_ | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: new => assigned
* owner: nobody => Carlton Gibson
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:9>
Django
files
-------------------------------------+-------------------------------------
Reporter: rm_ | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by GitHub <noreply@…>):
In [changeset:"b39bd0aa6d5667d6bbcf7d349a1035c676e3f972" b39bd0aa]:
{{{
#!CommitTicketReference repository=""
revision="b39bd0aa6d5667d6bbcf7d349a1035c676e3f972"
Refs #30175 -- Added release notes for 2.1.7, 2.0.12, and 1.11.20
releases.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:10>
Django
files
-------------------------------------+-------------------------------------
Reporter: rm_ | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"1672ed5ccf1215999ec478383a59527335170895" 1672ed5c]:
{{{
#!CommitTicketReference repository=""
revision="1672ed5ccf1215999ec478383a59527335170895"
[2.2.x] Refs #30175 -- Added release notes for 2.1.7, 2.0.12, and 1.11.20
releases.
Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:11>
Django
files
-------------------------------------+-------------------------------------
Reporter: rm_ | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"168bfdd92b8bf74313fb80ca4ac707d42a1ecc5c" 168bfdd]:
{{{
#!CommitTicketReference repository=""
revision="168bfdd92b8bf74313fb80ca4ac707d42a1ecc5c"
[2.1.x] Refs #30175 -- Added release notes for 2.1.7, 2.0.12, and 1.11.20
releases.
Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:12>
Django
files
-------------------------------------+-------------------------------------
Reporter: rm_ | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"11485a349b20cc8775cc17c51f3b1a05c5fc5c3d" 11485a3]:
{{{
#!CommitTicketReference repository=""
revision="11485a349b20cc8775cc17c51f3b1a05c5fc5c3d"
[2.0.x] Refs #30175 -- Added release notes for 2.0.12, and 1.11.20
releases.
Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:13>
Django
files
-------------------------------------+-------------------------------------
Reporter: rm_ | Owner: Carlton
| Gibson
Type: Bug | Status: assigned
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Carlton Gibson <carlton.gibson@…>):
In [changeset:"f2c5f66c7c7212721ce2de6a44dfd828c7268c16" f2c5f66c]:
{{{
#!CommitTicketReference repository=""
revision="f2c5f66c7c7212721ce2de6a44dfd828c7268c16"
[1.11.x] Refs #30175 -- Added release notes for 1.11.20 release.
Backport of b39bd0aa6d5667d6bbcf7d349a1035c676e3f972 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:14>
Django
files
-------------------------------------+-------------------------------------
Reporter: rm_ | Owner: Carlton
| Gibson
Component: Core (Other) | Version: 1.11
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: assigned => closed
* resolution: => fixed
Comment:
OK, so this should be fixed. New releases are up. Packages look correct.
Running the test suite against the src-dist release reveals no issues.
Sorry for the inconvenience.
--
Ticket URL: <https://code.djangoproject.com/ticket/30175#comment:15>