Re: [Django] #11560: let proxy models multiple-inherit from the same concrete base model
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 1.1-beta
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by gzerone@…):
Hi rfk, thanks for the patch file, it works for me. Hope the feature will
work on master branch.
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 1.1-beta
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by Griatch):
This has been lurking around for a long time, any idea when this might
merge into master? The patch seems to have unittest information now and
the feature itself is working. We would much like to use this feature
without having to patch django itself.
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: 1.1-beta
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 1
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by timgraham):
The patch needs to be updated to apply cleanly. If you can update it and
send a pull request, that will help. Also a mention in the release notes
and a `.. versionchanged:: 1.8` annotation would be helpful. See our
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#patch-review-checklist patch review checklist].
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:10>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by auvipy):
* status: new => assigned
* owner: nobody => auvipy
* version: 1.1-beta => master
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: auvipy
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by auvipy):
Replying to [comment:10 timgraham]:
> The patch needs to be updated to apply cleanly. If you can update it and
send a pull request, that will help. Also a mention in the release notes
and a `.. versionchanged:: 1.8` annotation would be helpful. See our
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#patch-review-checklist patch review checklist].
Hi Tim,
Is this issue already resolved by other works ? or I should work on the
patch to implement it cleanly?
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: auvipy
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by timgraham):
I don't know of any work that would have resolved this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:13>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: auvipy => akki
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: akki
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by akki):
* needs_better_patch: 1 => 0
Comment:
PR: https://github.com/django/django/pull/6346/
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: akki
Type: New feature | Status: assigned
Component: Database layer | Version: master
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_docs: 1 => 0
Comment:
Left a few comments for improvement.
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: rfk | Owner: akki
Component: Database layer | Version: master
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"49f95cc0a0167e91fd0f6987428905911bff076c" 49f95cc0]:
{{{
#!CommitTicketReference repository=""
revision="49f95cc0a0167e91fd0f6987428905911bff076c"
Fixed #11560 -- Allowed proxy model multiple-inheritance from the same
concrete base model.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/11560#comment:17>