[Django] #25178: Raise Exception when DEFAULT_FROM_EMAIL is not set
Django
-----------------------------------+--------------------
Reporter: ronaldoldenburger | Owner: nobody
Type: Bug | Status: new
Component: Core (Mail) | Version: 1.8
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------
While using the PasswordResetForm I wasn't reminded that
DEFAULT_FROM_EMAIL was a needed setting and was not set. This resulted in
a non working PasswordResetForm and thus there was no email send. As I did
had the SERVER_EMAIL set I thought this would be sufficient.
--
Ticket URL: <https://code.djangoproject.com/ticket/25178>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: ronaldoldenburger | Owner: nobody
Type: Bug | Status: new
Component: Core (Mail) | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 0
UI/UX: 0 |
Changes (by timgraham):
* Attachment "25178.diff" added.
Django
Reporter: ronaldoldenburger | Owner: nobody
Type: Bug | Status: new
Component: Core (Mail) | Version: 1.8
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
I am not sure exactly where you propose to raise the exception, but if I
understand correctly, it's probably not an option due to backwards
compatibility as the "unset" option for `DEFAULT_FROM_EMAIL` is actually
"webmaster@localhost".
How about the attached enhancement to the deployment checklist instead?
--
Ticket URL: <https://code.djangoproject.com/ticket/25178#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: ronaldoldenburger | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* component: Core (Mail) => Documentation
* has_patch: 0 => 1
* stage: Unreviewed => Ready for checkin
* type: Bug => Cleanup/optimization
--
Ticket URL: <https://code.djangoproject.com/ticket/25178#comment:2>
Django
-------------------------------------+-------------------------------------
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.8
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"ae32f324981dd64d7c04fcbed9d99356914a61de" ae32f32]:
{{{
#!CommitTicketReference repository=""
revision="ae32f324981dd64d7c04fcbed9d99356914a61de"
Fixed #25178 -- Added DEFAULT_FROM_EMAIL to deployment checklist.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25178#comment:3>
Django
-------------------------------------+-------------------------------------
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"fc279ed29841c3bdabe99b45881373e42187d82a" fc279ed2]:
{{{
#!CommitTicketReference repository=""
revision="fc279ed29841c3bdabe99b45881373e42187d82a"
[1.8.x] Fixed #25178 -- Added DEFAULT_FROM_EMAIL to deployment checklist.
Backport of ae32f324981dd64d7c04fcbed9d99356914a61de from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25178#comment:4>