[Django] #25900: CommonMiddleware's USE_ETAGS broken
Django
-------------------------------------+--------------------
Reporter: derekjamescurtis | Owner: nobody
Type: Uncategorized | Status: new
Component: Core (Cache system) | Version: 1.9
Severity: Normal | Keywords: ETags
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+--------------------
ETag support is broken in CommonMiddleware
This appears to have been broken here:
https://github.com/django/django/commit/7a40fef17ab7918cbb1ddc3ba080f42b420f7a48
#diff-1f8be0eae49a1bf37d52829eaeda6a4e
django.utils.cache.**get_conditional_response**'s etag argument needs to
be *unquoted*, however the etag passed by CommonMiddleware's make_response
is quoted.
Pull Request with Regression Test:
https://github.com/django/django/pull/5803
--
Ticket URL: <https://code.djangoproject.com/ticket/25900>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: derekjamescurtis | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: 1.9
Keywords: ETags | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by derekjamescurtis):
* needs_docs: => 0
* type: Uncategorized => Bug
* needs_tests: => 0
* needs_better_patch: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/25900#comment:1>
Django
Reporter: derekjamescurtis | Owner: nobody
Type: Bug | Status: new
Component: Core (Cache system) | Version: 1.9
Keywords: ETags | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by timgraham):
* easy: 1 => 0
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25900#comment:2>
Django
Reporter: derekjamescurtis | Owner: nobody
Type: Bug | Status: closed
Component: Core (Cache system) | Version: 1.9
Keywords: ETags | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Tim Graham <timograham@…>):
In [changeset:"364d7d969039bd14d3072a5ed035b88b44d855fd" 364d7d9]:
{{{
#!CommitTicketReference repository=""
revision="364d7d969039bd14d3072a5ed035b88b44d855fd"
[1.9.x] Fixed #25900 -- Fixed regression in CommonMiddleware ETag support.
Backport of 6be9589eb34f79914666c9d9e1e15bdb7fc44df2 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25900#comment:4>
Django
Reporter: derekjamescurtis | Owner: nobody
Type: Bug | Status: closed
Component: Core (Cache system) | Version: 1.9
Keywords: ETags | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"6be9589eb34f79914666c9d9e1e15bdb7fc44df2" 6be9589e]:
{{{
#!CommitTicketReference repository=""
revision="6be9589eb34f79914666c9d9e1e15bdb7fc44df2"
Fixed #25900 -- Fixed regression in CommonMiddleware ETag support.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25900#comment:3>