[Django] #31718: changepassword command should pass update_fields to user.save()
Django
-------------------------------------+-------------------------------------
Reporter: | Owner: nobody
marceltschoppch |
Type: | Status: new
Uncategorized |
Component: Core | Version: 3.0
(Management commands) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
The `changepassword` command should pass `update_fields=("password",)`
when saving the user.
--
Ticket URL: <https://code.djangoproject.com/ticket/31718>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
| marceltschoppch
Type: Uncategorized | Status: assigned
Component: Core (Management | Version: 3.0
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => marceltschoppch
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/31718#comment:1>
Django
-------------------------------------+-------------------------------------
| Tschopp
Type: Uncategorized | Status: assigned
Component: Core (Management | Version: 3.0
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Simon Charette):
Not sure this is desirable as it breaks any custom `User` model with an
`updated_at = models.DateTimeField(auto_now=True)` field.
If `updated_fields` is used this potential field won't be updated on a
password change through the management command anymore.
I'm inclined to 'wontfix' this ticket since `update_fields` would bring
little benefit with a slightly backward incompatible behaviour in this
case.
--
Ticket URL: <https://code.djangoproject.com/ticket/31718#comment:2>
Django
-------------------------------------+-------------------------------------
| Tschopp
Type: Uncategorized | Status: assigned
Component: Core (Management | Version: 3.0
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Marcel Tschopp):
Now that you say it, I think you are right. I also don't see any decent
solution to make this configurable or extendable.
Should I close my PR?
--
Ticket URL: <https://code.djangoproject.com/ticket/31718#comment:3>
Django
-------------------------------------+-------------------------------------
| Tschopp
Component: Core (Management | Version: 3.0
commands) |
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => wontfix
Comment:
I agree with Simon.
--
Ticket URL: <https://code.djangoproject.com/ticket/31718#comment:4>