[Django] #24875: inotify broken with vim, dev server does not restart
Django
--------------------------------------------+--------------------
Reporter: chrisbainbridge | Owner: nobody
Type: Bug | Status: new
Component: Core (Management commands) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 1 | UI/UX: 0
--------------------------------------------+--------------------
Commit 15f82c7 ("used pyinotify as change detection system when
available") introduced a regression where editing a file in vim with
default settings (writebackup=auto) would no longer cause the dev server
to be restarted. On a write, vim moves the monitored file to a backup
path, and then creating a new file in the original. The new file is not
monitored as it has a different inode. Fix this by also watching for
inotify events IN_DELETE_SELF and IN_MOVE_SELF.
--
Ticket URL: <https://code.djangoproject.com/ticket/24875>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: chrisbainbridge | Owner: nobody
Type: Bug | Status: new
Component: Core (Management commands) | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Easy pickings: 1
UI/UX: 0 |
Changes (by chrisbainbridge):
* Attachment "0001-Detect-moved-file-when-using-inotify-polling.patch"
added.
Django
Reporter: chrisbainbridge | Owner: nobody
Type: Bug | Status: new
commands) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
I'm unable to reproduce this, but maybe my vim is configured differently.
I have vim 7.4.52 (default that comes with Ubuntu 14.04). `:set
writebackup?` yields `writebackup` (no mention of "auto"). Could you
clarify how to reproduce? Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/24875#comment:1>
Django
Reporter: chrisbainbridge | Owner: nobody
Type: Bug | Status: closed
Component: Core (Management | Version: master
commands) |
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Changes (by claudep):
* status: new => closed
* resolution: => duplicate
Comment:
This was already reported in #23882
--
Ticket URL: <https://code.djangoproject.com/ticket/24875#comment:2>