[Django] #22826: Simplify Query.setup_joins
Django
----------------------------------------------+----------------------------
Reporter: jorgecarleitao | Owner: jorgecarleitao
Type: Cleanup/optimization | Status: new
Component: Database layer (models, ORM) | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+----------------------------
Currently, not all arguments returned by Query.setup_joins are being used
all the times.
On the other hand, some arguments are systematically being used in common
things (e.g. join_list[-1])
I propose to have a minor cleanup on these as part of an effort to
simplify the entanglement between
Query, SQLCompiler, and SQLEvalutor.
This is a minor simplification and doesn't affect any public API.
--
Ticket URL: <https://code.djangoproject.com/ticket/22826>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: jorgecarleitao | Owner:
Type: | jorgecarleitao
Cleanup/optimization | Status: new
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jorgecarleitao):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
This is easier to explain with code... I will submit a PR to explain what
I mean.
--
Ticket URL: <https://code.djangoproject.com/ticket/22826#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: jorgecarleitao | Owner:
Type: | jorgecarleitao
Component: Database layer | Version: master
(models, ORM) | Resolution:
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jorgecarleitao):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/22826#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: jorgecarleitao | Owner:
Type: | jorgecarleitao
Component: Database layer | Version: master
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jorge C. Leitão <jorgecarleitao@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"e66896226a41eb9e56b08d7adf29b44c0cd87dad"]:
{{{
#!CommitTicketReference repository=""
revision="e66896226a41eb9e56b08d7adf29b44c0cd87dad"
Fixed #22826 -- Improved internal usage of Query.setup_joins.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22826#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: jorgecarleitao | Owner:
Type: | jorgecarleitao
Cleanup/optimization | Status: closed
Component: Database layer | Version: master
(models, ORM) | Resolution: fixed
Severity: Normal | Triage Stage:
Keywords: | Unreviewed
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Marc Tamlyn <marc.tamlyn@…>):
In [changeset:"dd57b89fcb8f009fc73f16efea9539e5888eb59d"]:
{{{
#!CommitTicketReference repository=""
revision="dd57b89fcb8f009fc73f16efea9539e5888eb59d"
Merge pull request #2806 from jorgecarleitao/issue22826
Fixed #22826 -- Improved internal usage of Query.setup_joins.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22826#comment:4>