[Django] #33203: OrderedSet should inherit from collections.abc.MutableSet

16 views
Skip to first unread message

Django

unread,
Oct 16, 2021, 7:03:29 AM10/16/21
to django-...@googlegroups.com
#33203: OrderedSet should inherit from collections.abc.MutableSet
------------------------------------------+--------------------------------
Reporter: kumaraditya303 | Owner: kumaraditya303
Type: Uncategorized | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+--------------------------------


--
Ticket URL: <https://code.djangoproject.com/ticket/33203>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 16, 2021, 7:14:49 AM10/16/21
to django-...@googlegroups.com
#33203: OrderedSet should inherit from collections.abc.MutableSet
--------------------------------+------------------------------------------

Reporter: kumaraditya303 | Owner: kumaraditya303
Type: Uncategorized | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------

Comment (by kumaraditya303):

https://github.com/django/django/pull/15000

--
Ticket URL: <https://code.djangoproject.com/ticket/33203#comment:1>

Django

unread,
Oct 16, 2021, 8:19:12 AM10/16/21
to django-...@googlegroups.com
#33203: OrderedSet should inherit from collections.abc.MutableSet
--------------------------------+------------------------------------------

Reporter: kumaraditya303 | Owner: kumaraditya303
Type: Uncategorized | Status: assigned
Component: Utilities | Version: dev
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------

Comment (by Tim Graham):

You should describe the rationale in the ticket description.

--
Ticket URL: <https://code.djangoproject.com/ticket/33203#comment:2>

Django

unread,
Oct 18, 2021, 1:20:53 AM10/18/21
to django-...@googlegroups.com
#33203: OrderedSet should inherit from collections.abc.MutableSet
-------------------------------------+-------------------------------------
Reporter: kumaraditya303 | Owner:
Type: | kumaraditya303
Cleanup/optimization | Status: closed
Component: Utilities | Version: dev
Severity: Normal | Resolution: needsinfo

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: assigned => closed
* type: Uncategorized => Cleanup/optimization
* resolution: => needsinfo


Comment:

> You should describe the rationale in the ticket description.

Yes. Moreover, I don't see how `OrderedSet` implements `MutableSet` as
described in [https://www.python.org/dev/peps/pep-3119/#sets PEP 3119].

--
Ticket URL: <https://code.djangoproject.com/ticket/33203#comment:3>

Reply all
Reply to author
Forward
0 new messages