[Django] #30031: Add makemigrations/squashmigrations options to suppress version/date in migration header comment

29 views
Skip to first unread message

Django

unread,
Dec 11, 2018, 12:43:23 AM12/11/18
to django-...@googlegroups.com
#30031: Add makemigrations/squashmigrations options to suppress version/date in
migration header comment
-------------------------------------+-------------------------------------
Reporter: Dakota | Owner: nobody
Hawkins |
Type: | Status: new
Cleanup/optimization |
Component: Core | Version: master
(Management commands) | Keywords: migrations,
Severity: Normal | makemigrations
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
From discussion around the [https://github.com/django/django/pull/10741
PR] for [https://code.djangoproject.com/ticket/30029 #32009]

A new `makemigrations`/`squashmigrations` option `--no-header` should
prevent the Django version and date from being written to migration file
header comments.

This will prevent unnecessary VCS churn in cases where that information
isn't required and will help to make migration files more deterministic.

--
Ticket URL: <https://code.djangoproject.com/ticket/30031>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 11, 2018, 12:43:35 AM12/11/18
to django-...@googlegroups.com
#30031: Add makemigrations/squashmigrations options to suppress version/date in
migration header comment
-------------------------------------+-------------------------------------
Reporter: Dakota Hawkins | Owner: Dakota
Type: | Hawkins
Cleanup/optimization | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: migrations, | Triage Stage:
makemigrations | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Dakota Hawkins):

* owner: nobody => Dakota Hawkins
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/30031#comment:1>

Django

unread,
Dec 11, 2018, 12:44:37 AM12/11/18
to django-...@googlegroups.com
#30031: Add makemigrations/squashmigrations options to suppress version/date in
migration header comment
-------------------------------------+-------------------------------------
Reporter: Dakota Hawkins | Owner: Dakota
| Hawkins
Type: New feature | Status: assigned

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: migrations, | Triage Stage: Accepted
makemigrations |
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* type: Cleanup/optimization => New feature
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/30031#comment:2>

Django

unread,
Dec 11, 2018, 1:05:00 AM12/11/18
to django-...@googlegroups.com
#30031: Add makemigrations/squashmigrations options to suppress version/date in
migration header comment
-------------------------------------+-------------------------------------
Reporter: Dakota Hawkins | Owner: Dakota
| Hawkins
Type: New feature | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: migrations, | Triage Stage: Accepted
makemigrations |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Dakota Hawkins):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/10743 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/30031#comment:3>

Django

unread,
Dec 11, 2018, 2:39:02 AM12/11/18
to django-...@googlegroups.com
#30031: Add makemigrations/squashmigrations options to suppress version/date in
migration header comment
-------------------------------------+-------------------------------------
Reporter: Dakota Hawkins | Owner: Dakota
| Hawkins
Type: New feature | Status: assigned
Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution:
Keywords: migrations, | Triage Stage: Ready for
makemigrations | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/30031#comment:4>

Django

unread,
Dec 19, 2018, 6:42:11 AM12/19/18
to django-...@googlegroups.com
#30031: Add makemigrations/squashmigrations options to suppress version/date in
migration header comment
-------------------------------------+-------------------------------------
Reporter: Dakota Hawkins | Owner: Dakota
| Hawkins
Type: New feature | Status: closed

Component: Core (Management | Version: master
commands) |
Severity: Normal | Resolution: fixed

Keywords: migrations, | Triage Stage: Ready for
makemigrations | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Carlton Gibson <carlton.gibson@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"8d3147e130c4e5638fceb1e6125c040362ce12e8" 8d3147e1]:
{{{
#!CommitTicketReference repository=""
revision="8d3147e130c4e5638fceb1e6125c040362ce12e8"
Fixed #30031 -- Added --no-header option to
makemigrations/squashmigrations.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30031#comment:5>

Reply all
Reply to author
Forward
0 new messages