[Django] #33206: Allow redirect type choice in contrib.redirects app

23 views
Skip to first unread message

Django

unread,
Oct 16, 2021, 5:38:01 PM10/16/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
---------------------------------------------+------------------------
Reporter: Niccolò Mineo | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.redirects | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
I would like to propose allowing the user to choose the redirect type
(301, 302 and 410 by default) when adding a redirect in the
contrib.redirects app admin site.

--
Ticket URL: <https://code.djangoproject.com/ticket/33206>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 16, 2021, 5:40:52 PM10/16/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
-----------------------------------+--------------------------------------

Reporter: Niccolò Mineo | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.redirects | Version: 3.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Description changed by Niccolò Mineo:

Old description:

> I would like to propose allowing the user to choose the redirect type
> (301, 302 and 410 by default) when adding a redirect in the
> contrib.redirects app admin site.

New description:

I would like to propose allowing the user to choose the redirect type
(301, 302 and 410 by default) when adding a redirect in the
contrib.redirects app admin site.

[https://github.com/django/django/pull/15002 PR] is here.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33206#comment:1>

Django

unread,
Oct 16, 2021, 5:41:17 PM10/16/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
-----------------------------------+--------------------------------------

Reporter: Niccolò Mineo | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.redirects | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Niccolò Mineo):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/33206#comment:2>

Django

unread,
Oct 16, 2021, 5:47:42 PM10/16/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
-----------------------------------+--------------------------------------

Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: contrib.redirects | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Changes (by Niccolò Mineo):

* type: Uncategorized => New feature


--
Ticket URL: <https://code.djangoproject.com/ticket/33206#comment:3>

Django

unread,
Oct 17, 2021, 5:45:47 AM10/17/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
-----------------------------------+--------------------------------------

Reporter: Niccolò Mineo | Owner: nobody
Type: New feature | Status: new
Component: contrib.redirects | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+--------------------------------------
Description changed by Niccolò Mineo:

Old description:

> I would like to propose allowing the user to choose the redirect type


> (301, 302 and 410 by default) when adding a redirect in the
> contrib.redirects app admin site.

New description:

As [https://groups.google.com/g/django-developers/c/c_ghDNzAN50 originally
discussed], I would like to propose allowing the user to choose the


redirect type (301, 302 and 410 by default) when adding a redirect in the
contrib.redirects app admin site.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/33206#comment:4>

Django

unread,
Oct 18, 2021, 12:35:20 AM10/18/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
-------------------------------------+-------------------------------------
Reporter: Niccolò Mineo | Owner: Niccolò
| Mineo
Type: New feature | Status: assigned
Component: contrib.redirects | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* cc: Adam Johnson (added)
* needs_better_patch: 0 => 1
* status: new => assigned
* owner: nobody => Niccolò Mineo
* stage: Unreviewed => Accepted


Comment:

Thank for this proposition. Tentatively accepted, but only to allow
redirect type change (301, 302, 307, 308) per a redirect instance. PR
contains unrelated and backward incompatible changes e.g. swapping the
redirect model or a new behavior for `410 ("Gone")` redirects.

--
Ticket URL: <https://code.djangoproject.com/ticket/33206#comment:5>

Django

unread,
Oct 18, 2021, 3:14:49 AM10/18/21
to django-...@googlegroups.com
#33206: Allow redirect type choice in contrib.redirects app
-------------------------------------+-------------------------------------
Reporter: Niccolò Mineo | Owner: Niccolò
| Mineo
Type: New feature | Status: closed
Component: contrib.redirects | Version: 3.2
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: assigned => closed
* resolution: => wontfix
* stage: Accepted => Unreviewed


Comment:

This change is backward incompatible and against our stability policy. We
also don't have a clear migration path for existing users. We should go
back to the mailing list and reach a strong consensus before moving it
forward.

Closing as "wontfix".

--
Ticket URL: <https://code.djangoproject.com/ticket/33206#comment:6>

Reply all
Reply to author
Forward
0 new messages