[Django] #33389: Admin label contrast issues & light background elements in dark mode

10 views
Skip to first unread message

Django

unread,
Dec 28, 2021, 4:05:26 AM12/28/21
to django-...@googlegroups.com
#33389: Admin label contrast issues & light background elements in dark mode
------------------------------------------------+------------------------
Reporter: Hrushikesh Vaidya | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 4.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
------------------------------------------------+------------------------
When the `dark_mode.css` stylesheet is loaded in the admin when a client
prefers dark mode, the admin's `label` tags are still given a color from
the `forms.css` stylesheet, which results in the label elements having
very poor contrast with the dark background of the body.

Moreover, some elements in the admin UI, like `.submit-row` and
`.selector-available h2` are given light background colors that come from
their respective stylesheets.

--
Ticket URL: <https://code.djangoproject.com/ticket/33389>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 28, 2021, 4:06:24 AM12/28/21
to django-...@googlegroups.com
#33389: Admin label contrast issues & light background elements in dark mode
-------------------------------------+-------------------------------------

Reporter: Hrushikesh Vaidya | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Hrushikesh Vaidya):

* Attachment "contrast-bug.jpg" added.

Django

unread,
Dec 28, 2021, 4:06:34 AM12/28/21
to django-...@googlegroups.com
#33389: Admin label contrast issues & light background elements in dark mode
-------------------------------------+-------------------------------------

Reporter: Hrushikesh Vaidya | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Hrushikesh Vaidya):

* Attachment "contrast-bug-2.jpg" added.

Django

unread,
Dec 28, 2021, 4:35:34 AM12/28/21
to django-...@googlegroups.com
#33389: Admin label contrast issues & light background elements in dark mode
-------------------------------------+-------------------------------------

Reporter: Hrushikesh Vaidya | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution:

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* Attachment "Screenshot_20211228_103309.png" added.

Django

unread,
Dec 28, 2021, 4:41:45 AM12/28/21
to django-...@googlegroups.com
#33389: Admin label contrast issues & light background elements in dark mode
-------------------------------------+-------------------------------------

Reporter: Hrushikesh Vaidya | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: 4.0
Severity: Normal | Resolution: needsinfo

Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* status: new => closed
* resolution: => needsinfo


Comment:

Thanks for the report, however it works for me:

[[Image(Screenshot_20211228_103309.png)]]

Can you provide a sample project that reproduces this issue?

--
Ticket URL: <https://code.djangoproject.com/ticket/33389#comment:1>

Reply all
Reply to author
Forward
0 new messages