[Django] #23600: Overriding several settings is ignored by default_storage.

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner: nobody
Type: Bug | Status: new
Component: File | Version: master
uploads/storage | Keywords: testing
Severity: Normal | override_settings
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
django.core.files.storage.default_storage keeps a local copy of, and
doesn't take account of changes to, the following settings:

MEDIA_URL
FILE_UPLOAD_PERMISSIONS
FILE_UPLOAD_DIRECTORY_PERMISSIONS

This is the problem noted and fixed in #17744 for MEDIA_ROOT and noted in
general in #17787.

--
Ticket URL: <https://code.djangoproject.com/ticket/23600>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner:

Type: Bug | duncanparkes
Component: File | Status: assigned
uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage:
override_settings | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by duncanparkes):

* owner: nobody => duncanparkes
* needs_better_patch: => 0
* status: new => assigned
* needs_tests: => 0
* needs_docs: => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/23600#comment:1>

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner:

Type: Bug | duncanparkes
Component: File | Status: assigned
uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage:
override_settings | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by duncanparkes):

I have a branch ready to pull request for this, but GitHub is misbehaving
for me right now.

--
Ticket URL: <https://code.djangoproject.com/ticket/23600#comment:2>

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner:

Type: Bug | duncanparkes
Component: File | Status: assigned
uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage:
override_settings | Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by duncanparkes):

Pull request here: https://github.com/django/django/pull/3304

--
Ticket URL: <https://code.djangoproject.com/ticket/23600#comment:3>

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner:

Type: Bug | duncanparkes
Component: File | Status: assigned
uploads/storage | Version: master
Severity: Normal | Resolution:

Keywords: testing | Triage Stage: Accepted
override_settings | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by collinanderson):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/23600#comment:4>

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner:

Type: Bug | duncanparkes
Component: File | Status: assigned
uploads/storage | Version: master
Severity: Normal | Resolution:
Keywords: testing | Triage Stage: Accepted
override_settings | Needs documentation: 0

Has patch: 1 | Patch needs improvement: 1

Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by timgraham):

* needs_better_patch: 0 => 1

Comment:

Left comments for improvement on the PR.

--
Ticket URL: <https://code.djangoproject.com/ticket/23600#comment:5>

[Django]

#23600: Overriding several settings is ignored by default_storage.
-------------------------------------+-------------------------------------
Reporter: duncanparkes | Owner:

Type: Bug | duncanparkes
Component: File | Status: closed
uploads/storage | Version: master
Severity: Normal | Resolution: fixed

Keywords: testing | Triage Stage: Accepted
override_settings | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"88b6cf4ae41a983bda735a5f61f69f6b1482e2ca"]:
{{{
#!CommitTicketReference repository=""
revision="88b6cf4ae41a983bda735a5f61f69f6b1482e2ca"
Fixed #23600 -- Made default_storage aware of more settings changes.

Added MEDIA_URL, FILE_UPLOAD_PERMISSIONS, and
FILE_UPLOAD_DIRECTORY_PERMISSIONS to the list of settings.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23600#comment:6>