[Django] #26713: Recommend running tests with deprecation warnings, prior to upgrade.

1 view
Skip to first unread message

Django

unread,
Jun 6, 2016, 6:20:54 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
--------------------------------------+--------------------
Reporter: tomchristie | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+--------------------
Currently the upgrade docs recommend upgrading Django, and then working
through the tests with deprecation warnings turned on.

Really we ought to recommend working through the tests with deprecation
warnings turned on *first* prior to upgrading.

Further discussion on this at https://groups.google.com/forum/#!topic
/django-developers/tz40MK4AOjo

--
Ticket URL: <https://code.djangoproject.com/ticket/26713>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 6, 2016, 6:40:42 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
-------------------------------------+-------------------------------------
Reporter: tomchristie | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by tomchristie):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


Comment:

PR: https://github.com/django/django/pull/6732

--
Ticket URL: <https://code.djangoproject.com/ticket/26713#comment:1>

Django

unread,
Jun 6, 2016, 6:47:26 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
-------------------------------------+-------------------------------------
Reporter: tomchristie | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by tomchristie):

Also related - link prominently to the upgrade docs from the release
notes.

PR: https://github.com/django/django/pull/6733

--
Ticket URL: <https://code.djangoproject.com/ticket/26713#comment:2>

Django

unread,
Jun 6, 2016, 7:59:47 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
--------------------------------------+------------------------------------

Reporter: tomchristie | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

I merged the second PR and left a few comments for improvement on the
first.

--
Ticket URL: <https://code.djangoproject.com/ticket/26713#comment:3>

Django

unread,
Jun 6, 2016, 11:41:40 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
--------------------------------------+------------------------------------
Reporter: tomchristie | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"316395d82874beea6af08a873e91b1880d0b982a" 316395d8]:
{{{
#!CommitTicketReference repository=""
revision="316395d82874beea6af08a873e91b1880d0b982a"
Fixed #26713 -- Documented resolving deprecation warnings before upgrade.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26713#comment:4>

Django

unread,
Jun 6, 2016, 11:41:51 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
--------------------------------------+------------------------------------
Reporter: tomchristie | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"73d64a020cedebb6d78f8b3e2355a10b7a663635" 73d64a02]:
{{{
#!CommitTicketReference repository=""
revision="73d64a020cedebb6d78f8b3e2355a10b7a663635"
[1.9.x] Fixed #26713 -- Documented resolving deprecation warnings before
upgrade.

Backport of 316395d82874beea6af08a873e91b1880d0b982a from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26713#comment:5>

Django

unread,
Jun 6, 2016, 11:41:57 AM6/6/16
to django-...@googlegroups.com
#26713: Recommend running tests with deprecation warnings, prior to upgrade.
--------------------------------------+------------------------------------
Reporter: tomchristie | Owner: nobody
Type: Cleanup/optimization | Status: closed
Component: Documentation | Version: master

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"d9b78be324cb2ccc331a7c27ec2d677a2d219fae" d9b78be]:
{{{
#!CommitTicketReference repository=""
revision="d9b78be324cb2ccc331a7c27ec2d677a2d219fae"
[1.10.x] Fixed #26713 -- Documented resolving deprecation warnings before
upgrade.

Backport of 316395d82874beea6af08a873e91b1880d0b982a from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26713#comment:6>

Reply all
Reply to author
Forward
0 new messages