[Django] #26553: Seemingly redundant outer loop in views/i18n.py
Django
-------------------------------+--------------------
Reporter: markshannon | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 1.9
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
The outer loop here:
https://github.com/django/django/blob/master/django/views/i18n.py#L78
seems to be redundant.
The final value of `result` will be unchanged after the first iteration.
--
Ticket URL: <https://code.djangoproject.com/ticket/26553>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: markshannon | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):
* needs_better_patch: => 0
* component: Uncategorized => Internationalization
* needs_tests: => 0
* version: 1.9 => master
* easy: 0 => 1
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Absolutely, see commit [d44fb0557a0a9d8fab62b] to understand what
happened.
--
Ticket URL: <https://code.djangoproject.com/ticket/26553#comment:1>
Django
Reporter: markshannon | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: | Version: master
Internationalization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
* stage: Accepted => Ready for checkin
Comment:
[https://github.com/django/django/pull/6527 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/26553#comment:2>
Django
Reporter: markshannon | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: | Version: master
Internationalization |
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"0d8b523422fda71baa10807d5aebefd34bad7962" 0d8b523]:
{{{
#!CommitTicketReference repository=""
revision="0d8b523422fda71baa10807d5aebefd34bad7962"
Fixed #26553 -- Removed unneeded loop in views/i18n.py
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26553#comment:3>